I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

neg-c changed the title~~Added QR_Code data flip support, flip and retry after first EEC failure~~Added QR_Code data flip support, flip and retry after first ECC failure

Feb 18, 2023

asmorkalov requested a review fromAleksandrPanov

February 20, 2023 09:56

asmorkalov added feature category: objdetect labels

Feb 20, 2023

neg-c mentioned this pull request

Feb 23, 2023

Test data for mirrored qr codesopencv/opencv_extra#1046

Merged

Copy link

ContributorAuthor

neg-c commentedFeb 23, 2023

@alalek The test data for this PR is in :opencv_extra/pull/1046.

neg-c force-pushed thebug/issue-23249_detected_but_not_decoded_bug branch fromde7ea8d tode944b3Compare

February 23, 2023 21:15

Copy link

ContributorAuthor

neg-c commentedFeb 27, 2023

@alalek @AleksandrPanov Is there something left to do in this PR from my side ?

Copy link

Contributor

AleksandrPanov commentedMar 14, 2023•
edited
Loading

@genciberisha I found this issue in thequirc library:
QR code ECC failure #88
support horizontally flipped QR-codes according to ISO 18004:2015 #89

Your solution to the problem is correct, thank you. Test images must be converted to jpg to take up less space.

Copy link

Contributor

asmorkalov commentedMar 14, 2023•
edited
Loading

The PR contains 2 tests that are dependent. It's not stable solution for testing. I propose to remove generator part and hardcode information as static array. There are only 2 images, not need to dump regression data to file.

asmorkalov self-requested a review

March 14, 2023 11:06

neg-c force-pushed thebug/issue-23249_detected_but_not_decoded_bug branch 2 times, most recently from7b02524 to36bc181Compare

March 15, 2023 22:32

Copy link

ContributorAuthor

neg-c commentedMar 15, 2023•
edited
Loading

@AleksandrPanov Converting these images toJPG decreases the size a little but also with a lot off quality loss.
I managed to compress thesePNG file to under3kb size, hope that counts.

@asmorkalov Agreed, I removed the generation test and replaced it with a simple validation test.
Please note because of the nature of the bug we need to validate the data at the end, so I saw it reasonable to
to pack the filename and expected result as a std::pair.

asmorkalov approved these changes

Mar 16, 2023

View reviewed changes

AleksandrPanov approved these changes

Mar 20, 2023

View reviewed changes

Copy link

Contributor

AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@genciberisha, thank you
I consider this solution to be optimal, because it's likequirc's solution.

Added QR_Code data flip support, flip and retry after first EEC failure

a1b4aa5

Added regression test for the flipped images

neg-c force-pushed thebug/issue-23249_detected_but_not_decoded_bug branch from36bc181 toa1b4aa5Compare

March 20, 2023 13:28

Copy link

ContributorAuthor

neg-c commentedMar 21, 2023

@alalek Seems there isn't anything left here to do, thank you.

asmorkalov assignedAleksandrPanov

Mar 21, 2023

asmorkalov added this to the4.8.0 milestone

Mar 21, 2023

asmorkalov merged commite6bd4c9 intoopencv:4.x

Mar 21, 2023

Copy link

Contributor

opencv-alalek commentedApr 12, 2023

There isbuild error:

/build/4_x_ARMv7-lin/opencv/3rdparty/quirc/src/decode.c: In function 'quirc_flip':/build/4_x_ARMv7-lin/opencv/3rdparty/quirc/src/decode.c:923:9: warning: missing braces around initializer [-Wmissing-braces]  struct quirc_code flipped = {0};         ^/build/4_x_ARMv7-lin/opencv/3rdparty/quirc/src/decode.c:923:9: warning: (near initialization for 'flipped.corners') [-Wmissing-braces]/build/4_x_ARMv7-lin/opencv/3rdparty/quirc/src/decode.c:925:2: error: 'for' loop initial declarations are only allowed in C99 mode  for (int y = 0; y < code->size; y++) {  ^/build/4_x_ARMv7-lin/opencv/3rdparty/quirc/src/decode.c:925:2: note: use option -std=c99 or -std=gnu99 to compile your code/build/4_x_ARMv7-lin/opencv/3rdparty/quirc/src/decode.c:926:3: error: 'for' loop initial declarations are only allowed in C99 mode   for (int x = 0; x < code->size; x++) {   ^