I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Macbuild_gapi_standalone:Linux x64=ade-0.1.1fbuild_gapi_standalone:Win64=ade-0.1.1fbuild_gapi_standalone:Mac=ade-0.1.1fbuild_gapi_standalone:Linux x64 Debug=ade-0.1.1fXbuild_image:Custom=centos:7Xbuildworker:Custom=linux-1build_gapi_standalone:Custom=ade-0.1.1fbuild_image:Custom=ubuntu-openvino-2021.4.1:20.04build_image:Custom Win=openvino-2021.2.0build_image:Custom Mac=openvino-2021.2.0test_modules:Custom=gapi,python2,python3,javatest_modules:Custom Win=gapi,python2,python3,javatest_modules:Custom Mac=gapi,python2,python3,javabuildworker:Custom=linux-1# disabled due high memory usage: test_opencl:Custom=ONtest_opencl:Custom=OFFtest_bigdata:Custom=1test_filter:Custom=*

This PR is about porting of GStreamer streaming source for G-API pipeline functionality to public OpenCV.

AsyaPronina requested review fromTolyaTalamanov,dmatveev,rgarnov,sivanov-work andsmirnov-alexey

September 16, 2021 22:36

AsyaPronina force-pushed theasyadev/integrate_gstreamer_source branch 2 times, most recently from891445e to5a16a93Compare

September 16, 2021 23:55

asmorkalov added the category: g-api / gapi label

Sep 17, 2021

sivanov-work reviewed

Sep 20, 2021

View reviewed changes

Copy link

Contributor

sivanov-work left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please pay attention about GStreamerPtr assigning pointer ourselves problem at least. Moreover, from my perspective, whole class implementation is danger

modules/gapi/src/streaming/gstreamer/gstreamer_buffer_utils.cpp Outdated


		voidmapBufferToFrame(GstBuffer* buffer, GstVideoInfo* info, GstVideoFrame* frame,
		GstMapFlags mapFlags) {
		GAPI_Assert(info &&"GstVideoInfo is absent during GstBuffer mapping");

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can get rid of validity checking by passing references as argument (for buffer and frame also)

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed, thanks!

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hppShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamer_media_adapter.cpp Outdated

		GST_MAP_WRITE);
		m_mappedForWrite.store(true, std::memory_order_release);
		}else {
		gstreamer_utils::mapBufferToFrame(m_buffer, m_videoInfo, &m_videoFrame,

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thread 1, R: goes here and make mapBufferToFrame
thread 2, W goes line 67-68 and make gst_video_frame_unmap AND putfalse inm_isMapped <context switch)
thread 1, R awakes and setm_isMapped totrue at line 95.

Does this situation lead to broken invariants?

Copy link

ContributorAuthor

AsyaProninaOct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This situation should never happen according to framework design

modules/gapi/src/streaming/gstreamer/gstreamer_media_adapter.cppShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamerptr.hpp Outdated

		GStreamerPtr&operator=(GStreamerPtr&&) =delete;

		private:
		T* ptr;

Copy link

Contributor

sivanov-workSep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How's about to do not use home-grown implementation but default and highly-testedstd::unique_ptr with custom dtor :)

tempate<...>using GStreamerPtr = std::unique_ptr<Type, decltype(GStreamerPtrRelease<Type>)>make_ptr(Type* ptr) {return GStreamerPtr (ptr, &GStreamerPtrRelease<Type>);}

}

Copy link

ContributorAuthor

AsyaProninaOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is very good suggestion

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed! Thanks!

modules/gapi/src/streaming/gstreamer/gstreamersource.cpp Outdated

		m_outputType(outputType)
		{
		auto appsinks = m_pipeline->getElementsByFactoryName("appsink");
		GAPI_Assert(1ul == appsinks.size());

Copy link

Contributor

sivanov-workSep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What do you think to add warning log message additionally?

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think that this is very good idea

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed, thanks!

modules/gapi/src/streaming/gstreamer/gstreamersource.cpp Outdated

		}
		break;
		}
		default: {

Copy link

Contributor

sivanov-workSep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

from my point of view we should handle this situation at construction time

Copy link

ContributorAuthor

AsyaProninaOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't understand, what do you mean here? Could you please add some more details?

Copy link

Contributor

sivanov-workOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sure, I mean do not allow to create Source with invalidm_output here
https://github.com/opencv/opencv/pull/20709/files#diff-1387240a1379983779d72695d2b19e9c70195f80ab2784ef8dd3f4885cf78e3fR64

and to remove this switch-case like check from other part of a Source code

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Got the idea

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed, thanks!

modules/gapi/src/streaming/gstreamer/gstreamersource.cpp Outdated

		gst_app_sink_set_emit_signals(GST_APP_SINK(m_appsink.get()),FALSE);

		GStreamerPtr<GstCaps>nv12Caps(gst_caps_from_string(
		"video/x-raw,format=NV12;video/x-raw(memory:DMABuf),format=NV12"));/* transfer full*/

Copy link

Contributor

sivanov-workSep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

suggest to make global constant

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed, thanks!

modules/gapi/src/streaming/gstreamer/gstreamersource.cpp OutdatedShow resolvedHide resolved

AsyaPronina force-pushed theasyadev/integrate_gstreamer_source branch 4 times, most recently from0557257 to98ccf8fCompare

October 1, 2021 22:29

alalek reviewed

Oct 4, 2021

View reviewed changes

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamerpipeline.hpp Outdated

		//
		// Copyright 2021 Intel Corporation.
		//
		// This software and the related documents are Intel copyrighted materials,

Copy link

Member

alalekOct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Use the right license header.

Copy link

ContributorAuthor

AsyaProninaOct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the catch!

Copy link

ContributorAuthor

AsyaProninaOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed, thanks!

TolyaTalamanov reviewed

Oct 7, 2021

View reviewed changes

modules/gapi/CMakeLists.txt Outdated

		src/streaming/gstreamer/gstreamersource.cpp
		src/streaming/gstreamer/gstreamer_buffer_utils.cpp
		src/streaming/gstreamer/gstreamer_media_adapter.cpp
		src/streaming/gstreamer/gstreamerinit.cpp

Copy link

Contributor

TolyaTalamanovOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't forget to add:
"${CMAKE_CURRENT_LIST_DIR}/include/opencv2/${name}/streaming/gstreamer/*.hpp" togapi_ext_hdrs.
Could I also ask you to add:
"${CMAKE_CURRENT_LIST_DIR}/include/opencv2/${name}/streaming/onevpl/*.hpp" to there ?

Copy link

ContributorAuthor

AsyaProninaOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Sure!

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done, please check!

TolyaTalamanov reviewed

Oct 7, 2021

View reviewed changes

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp

		GStreamerSource(const std::string& pipeline,
		const GStreamerSource::OutputType outputType =
		GStreamerSource::OutputType::MAT);
		GStreamerSource(std::shared_ptr<GStreamerPipelineFacade> pipeline,

Copy link

Contributor

TolyaTalamanovOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is thector really needed inpublic section ?
Since there is only forward declaration forGStreamerPipelineFacade it's supposed to be inprivate section

Copy link

ContributorAuthor

AsyaProninaOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, no, this one is used inGStreamerPipeline class, and these classes are not friends.

TolyaTalamanov reviewed

Oct 7, 2021

View reviewed changes

modules/gapi/test/streaming/gapi_gstreamersource_tests.cpp Outdated

		cv::GComputationc(cv::GIn(in),cv::GOut(out));

		// Graph compilation for streaming mode:
		auto ccomp = c.compileStreaming(std::move(cv::compile_args(cv::gapi::core::cpu::kernels())));

Copy link

Contributor

TolyaTalamanovOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

U don't need to pass this package explicitly, do you ?

Copy link

ContributorAuthor

AsyaProninaOct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, I don't, thanks!

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed, thanks!

Copy link

Contributor

TolyaTalamanov commentedOct 7, 2021

I've opened this one:#20832
based on your branch

Copy link

Contributor

TolyaTalamanov commentedOct 7, 2021•
edited
Loading

Whitespaces:

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp:33: trailing whitespace.+ * modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp:42: trailing whitespace.+ *        modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp:44: trailing whitespace.+ * modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp:51: trailing whitespace.+ * modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp:54: trailing whitespace.+ * modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp:70: trailing whitespace.+ modules/gapi/src/streaming/gstreamer/gstreamer_pipeline_facade.cpp:62: trailing whitespace.+// The destructors are noexcept by default (since C++11). modules/gapi/src/streaming/gstreamer/gstreamer_pipeline_facade.hpp:69: trailing whitespace.+    std::string m_pipelineDesc; modules/gapi/src/streaming/gstreamer/gstreamerinit.hpp:26: trailing whitespace.+ * modules/gapi/src/streaming/gstreamer/gstreamerinit.hpp:27: trailing whitespace.+ * modules/gapi/src/streaming/gstreamer/gstreamerptr.hpp:69: trailing whitespace.+{ modules/gapi/src/streaming/gstreamer/gstreamersource_priv.hpp:60: trailing whitespace.+    GstBuffer*                             m_buffer = nullptr; // Actual frame memory holder modules/gapi/test/streaming/gapi_gstreamer_pipeline_facade_int_tests.cpp:125: trailing whitespace.+    GstStateChangeReturn status = modules/gapi/test/streaming/gapi_gstreamersource_tests.cpp:66: trailing whitespace.+    // Streaming - pulling of frames until the end:  modules/gapi/test/streaming/gapi_gstreamersource_tests.cpp:333: trailing whitespace.+ modules/gapi/test/streaming/gapi_gstreamersource_tests.cpp:339: trailing whitespace.+    cv::gapi::wip::Data leftImData, rightImData; modules/gapi/test/streaming/gapi_gstreamersource_tests.cpp:347: trailing whitespace.+    std::tuple<cv::GComputation, cv::gapi::wip::GStreamerSource::OutputType> params = GetParam();

AsyaPronina force-pushed theasyadev/integrate_gstreamer_source branch from98ccf8f to37339d2Compare

October 7, 2021 23:30

sivanov-work approved these changes

Oct 8, 2021

View reviewed changes

Copy link

Contributor

sivanov-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

modules/gapi/src/streaming/gstreamer/gstreamer_media_adapter.cppShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamer_pipeline_facade.cpp

		"GStreamer pipeline has not been created!");

		PipelineState state;
		GstClockTime timeout = 5 * GST_SECOND;

Copy link

Contributor

sivanov-workOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Then what happened if query state would reach timeout?

modules/gapi/src/streaming/gstreamer/gstreamer_pipeline_facade.cppShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamerptr.hpp Outdated

		}
		}

		template<typename T>staticinlinevoidGStreamerPtrRelease(T** pPtr);

Copy link

Contributor

sivanov-workOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, i mean - use determined specializations for several types of T, but when user or-someone-else just call this function with something not related to correct GStreamer resource, forFoo class for example. Then correct specialization would not be deducted and compiler generated declaration forFoo, which has no body definition and user would face with LINK error, at least

The good approach is do not wait for LINK error but break compilation with some message usingstatic_assert

Something like that:

template<T> GStreamerRelease( T***) {static_assert(std::is_same<T, ...>::value,  "Unsupported type in GStreamer Release")}

The part withstd::is_same can be more intellectual with variadic templates

Feel free to ignore this comment

modules/gapi/src/streaming/gstreamer/gstreamersource.cpp Outdated

		}
		break;
		}
		default: {

Copy link

Contributor

sivanov-workOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sure, I mean do not allow to create Source with invalidm_output here
https://github.com/opencv/opencv/pull/20709/files#diff-1387240a1379983779d72695d2b19e9c70195f80ab2784ef8dd3f4885cf78e3fR64

and to remove this switch-case like check from other part of a Source code

OrestChura reviewed

Oct 8, 2021

View reviewed changes

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamer_pipeline.hpp OutdatedShow resolvedHide resolved

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp

Comment on lines +34 to +29

		* To create GStreamerSource instance you need to pass 'pipeline' and, optionally, 'outputType'
		* arguments into constructor.
		* 'pipeline' should represent GStreamer pipeline in form of textual description.
		* Almost any custom pipeline is supported which can be successfully ran via gst-launch.

Copy link

Contributor

OrestChuraSep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	* To create GStreamerSource instance you need to pass'pipeline'and, optionally,'outputType'
	* arguments into constructor.
	*'pipeline' should represent GStreamer pipeline in form of textual description.
	* Almost any custom pipeline is supported which can be successfullyran via gst-launch.
	* To createaGStreamerSource instance you need to pass'pipeline'and, optionally,'outputType'
	* arguments into constructor.
	*'pipeline' should representaGStreamer pipeline in form of textual description.
	* Almost any custom pipeline is supported which can be successfullyrun via gst-launch.

Copy link

ContributorAuthor

AsyaProninaOct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is irregular verb, this is why "ran" is used here

Copy link

Contributor

OrestChuraOct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, but here is 3rd form needed, which is "run"

Copy link

Contributor

OrestChuraOct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please consider to correct

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp OutdatedShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamer_media_adapter.hpp OutdatedShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamer_buffer_utils.hppShow resolvedHide resolved

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hppShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamer_pipeline_facade.hppShow resolvedHide resolved

modules/gapi/src/streaming/gstreamer/gstreamerpipeline_priv.hppShow resolvedHide resolved

AsyaPronina force-pushed theasyadev/integrate_gstreamer_source branch 5 times, most recently fromff807b5 to7c22705Compare

October 11, 2021 09:20

Copy link

ContributorAuthor

AsyaPronina commentedOct 15, 2021

GStreamer is built here;https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/6580/steps/cmake/logs/stdio

Copy link

ContributorAuthor

AsyaPronina commentedOct 15, 2021

GStreamer tests:https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/6580/steps/test_gapi/logs/stdio

AsyaPronina commented

Oct 18, 2021

View reviewed changes

modules/gapi/src/streaming/gstreamer/gstreamerenv.hpp


		#ifndef OPENCV_GAPI_STREAMING_GSTREAMER_GStreamerEnv_HPP
		#defineOPENCV_GAPI_STREAMING_GSTREAMER_GStreamerEnv_HPP

Copy link

ContributorAuthor

AsyaProninaOct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#ifdef HAVE_GSTREAMER?

OrestChura approved these changes

Oct 18, 2021

View reviewed changes

Copy link

Contributor

OrestChura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great!

modules/gapi/include/opencv2/gapi/streaming/gstreamer/gstreamersource.hpp

Comment on lines +34 to +29

		* To create GStreamerSource instance you need to pass 'pipeline' and, optionally, 'outputType'
		* arguments into constructor.
		* 'pipeline' should represent GStreamer pipeline in form of textual description.
		* Almost any custom pipeline is supported which can be successfully ran via gst-launch.

Copy link

Contributor

OrestChuraOct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please consider to correct

modules/gapi/src/streaming/gstreamer/gstreamer_pipeline_facade.cpp OutdatedShow resolvedHide resolved

AsyaPronina force-pushed theasyadev/integrate_gstreamer_source branch 5 times, most recently from6cf3d58 to0dd69f1Compare

November 14, 2021 21:58

AsyaPronina added2 commits

November 22, 2021 15:02

Ported GStreamerSource to OpenCV

80de5d2

Merge branch 'master' ofhttps://github.com/opencv/opencvinto asyade…

7a38fb0

…v/integrate_gstreamer_source

AsyaPronina force-pushed theasyadev/integrate_gstreamer_source branch from0dd69f1 to7a38fb0Compare

November 22, 2021 13:23

Fixed CI failures

94b0837

dmatveev added this to the4.5.5 milestone

Nov 26, 2021

mpashchenkov reviewed

Nov 29, 2021

View reviewed changes

modules/gapi/test/streaming/gapi_gstreamer_pipeline_facade_int_tests.cpp Outdated

		pipelineFacade.completePreroll();

		cv::gapi::wip::gst::GStreamerPtr<GstSample>prerollSample(
		// gst_app_sink_try_pull_preroll(GST_APP_SINK(appsink), 5 * GST_SECOND));

Copy link

Contributor

mpashchenkovNov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Debug code?

Copy link

ContributorAuthor

AsyaProninaNov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for a catch!! This code should be version-dependent!

Copy link

ContributorAuthor

AsyaProninaDec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed!

Pashchenkov Maxim added4 commits

November 29, 2021 15:40

Whitespaces

52a8992

Whitespaces + removed exception from destructors C4722

2b728e3

Removed assert for Priv's getSS and descr_of

4ac6ad2

Removed assert for pull

eec8141

Copy link

Contributor

OrestChura commentedDec 1, 2021

👍🏻

OrestChura reviewed

Dec 1, 2021

View reviewed changes

modules/gapi/test/streaming/gapi_gstreamersource_tests.cpp

Comment on lines +336 to +338

		std::tuple<cv::GComputation, cv::gapi::wip::GStreamerSource::OutputType> params =GetParam();
		cv::GComputation extractImage =std::move(std::get<0>(params));
		cv::gapi::wip::GStreamerSource::OutputType outputType = std::get<1>(params);

Copy link

Contributor

OrestChuraDec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

canstd::tie() be used here instead?

Suggested change

	std::tuple<cv::GComputation, cv::gapi::wip::GStreamerSource::OutputType> params = GetParam();
	cv::GComputation extractImage = std::move(std::get<0>(params));
	cv::gapi::wip::GStreamerSource::OutputType outputType= std::get<1>(params);
	cv::GComputation extractImage;
	cv::gapi::wip::GStreamerSource::OutputType outputType =/default value/0;
	std::tie(extractImage, outputType) = GetParam();

Is it because GComputation can't be declared like that?

dmatveev self-assigned this

Dec 6, 2021

dmatveev approved these changes

Dec 6, 2021

View reviewed changes

Copy link

Contributor

dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Merge this please

Copy link

Member

alalek commentedDec 6, 2021

PR should not be merged in current form due to broken compilation in Custom builder with GStreamer:

/build/precommit_custom_linux/4.x/opencv/modules/gapi/test/streaming/gapi_gstreamer_pipeline_facade_int_tests.cpp: In member function 'virtual void opencv_test::GStreamerPipelineFacadeTest_CompletePrerollUnitTest_Test::Body()':/build/precommit_custom_linux/4.x/opencv/modules/gapi/test/streaming/gapi_gstreamer_pipeline_facade_int_tests.cpp:95:13: error: 'gst_app_sink_try_pull_prerollGST_APP_SINK' was not declared in this scope; did you mean 'gst_app_sink_try_pull_preroll'?   95 |             gst_app_sink_try_pull_prerollGST_APP_SINK(appsink), 5 * GST_SECOND));      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      |             gst_app_sink_try_pull_preroll/build/precommit_custom_linux/4.x/opencv/modules/gapi/test/streaming/gapi_gstreamer_pipeline_facade_int_tests.cpp:95:80: error: expected ',' or ';' before ')' token   95 |             gst_app_sink_try_pull_prerollGST_APP_SINK(appsink), 5 * GST_SECOND));      |                                                                                ^make[2]: *** [modules/gapi/CMakeFiles/opencv_test_gapi.dir/build.make:1025: modules/gapi/CMakeFiles/opencv_test_gapi.dir/test/streaming/gapi_gstreamer_pipeline_facade_int_tests.cpp.o] Error 1

Fixed last review comment

97fadfc

AsyaPronina force-pushed theasyadev/integrate_gstreamer_source branch from5309176 to97fadfcCompare

December 6, 2021 14:42

alalek merged commit8dd6882 intoopencv:4.x

Dec 6, 2021

alalek mentioned this pull request

Dec 30, 2021

(5.x) Merge 4.x#21371

Merged

alalek mentioned this pull request

Feb 22, 2022

(5.x) Merge 4.x#21651

Merged

a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request

Mar 30, 2023

Merge pull requestopencv#20709from AsyaPronina:asyadev/integrate_gs…

5d864aa

…treamer_sourcePorted GStreamerSource to OpenCV* Ported GStreamerSource to OpenCV* Fixed CI failures* Whitespaces* Whitespaces + removed exception from destructors C4722* Removed assert for Priv's getSS and descr_of* Removed assert for pull* Fixed last review commentCo-authored-by: Pashchenkov Maxim <maxim.pashchenkov@intel.com>