Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix ONNXImporter diagnostic mode layer registration issue#20494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alalek merged 6 commits intoopencv:masterfromrogday:onnx_diagnostic_fix
Aug 20, 2021

Conversation

@rogday
Copy link
Member

In diagnostic mode it showed that some layer isn't supported even if it was registered beforehand.

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

asmorkalov reacted with thumbs up emoji
* @brief Skip model import after diagnostic run in readNet() functions.
* @param[in] skip Indicates whether to skip the import.
*/
CV_EXPORTSvoidskipModelImport(bool skip);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why do we need that as part of public API?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This function is used intest_tf_importer.cpp and prevents tests of diagnostic mode from failing. I agree that users probably shouldn't care about this. I couldn't move the definition todnn_common.hpp because of undefined reference error(implementation was placed indnn.cpp). Can you suggest a better place for it or how to get around this problem?

As for the contents oflayer_reg.private.hpp, I think removing it would be a breaking change, and so if someone is using it, they should be able to use it thread-safely.

…f DNN_DIAGNOSTICS_RUN between onnx and tf importers
@rogdayrogdayforce-pushed theonnx_diagnostic_fix branch 2 times, most recently from60b1d5d to3960253CompareAugust 11, 2021 11:16
@rogdayrogday marked this pull request as ready for reviewAugust 11, 2021 13:26
@asmorkalov
Copy link
Contributor

asmorkalov commentedAug 20, 2021•
edited by alalek
Loading

@alalek The failed test is not related to Rogday's changes. Could you take a look.

Issue about sporadic test failure is here:#10400

asmorkalov reacted with thumbs up emoji

Copy link
Member

@alalekalalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! Thank you 👍

@rogdayrogday marked this pull request as draftAugust 20, 2021 12:18
@rogday
Copy link
MemberAuthor

I found an error in TF logic.

@rogdayrogday marked this pull request as ready for reviewAugust 20, 2021 12:25
@alalekalalek merged commit6801dd0 intoopencv:masterAug 20, 2021
@rogdayrogday deleted the onnx_diagnostic_fix branchOctober 7, 2021 13:15
@alalekalalek mentioned this pull requestOct 15, 2021
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull requestMar 30, 2023
fix ONNXImporter diagnostic mode layer registration issue* fix layer registration, thread unsafe access and align the behavior of DNN_DIAGNOSTICS_RUN between onnx and tf importers* move skipModelInput* print all missing layers* address TF issue
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alalekalalekalalek approved these changes

Assignees

@alalekalalek

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@rogday@asmorkalov@alalek
[8]ページ先頭
©2009-2025 Movatter.jp