Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
Add Thickness parameter in drawMatches function#20232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This commit adds the feature of selecting the thicknessof the matches drawn by the drawMatches function.In larger images, the default thickness of 1 pixel creates imagesthat are hard to visualize.
alalek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me 👍
There are some low priority questions about:
- compatibility of Python bindings (we don't check them actually)
- documentation of parameters
| const std::vector<DMatch>& matches1to2, InputOutputArray outImg, | ||
| constint matchesThickness,const Scalar& matchColor=Scalar::all(-1), | ||
| const Scalar& singlePointColor=Scalar::all(-1),const std::vector<char>& matchesMask=std::vector<char>(), | ||
| int flags=DrawMatchesFlags::DEFAULT ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@vpisarev I believe we should define strategy about changes which should be migrated to OpenCV 5.0 major release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Regarding Python bindings: I've tested the code provided by the author of#20095 and it's working fine.
Regarding the documentation: the new parameter should be documented when it's only used in an overloaded function? If so, I can take a look at it.
My first try was to include it as a parameter of the original function, but some errors happened due to the function names inside of binary files, that's why I've created a new function.
Uh oh!
There was an error while loading.Please reload this page.
This commit adds the feature of selecting the thickness
of the matches drawn by the drawMatches function.
In larger images, the default thickness of 1 pixel creates images
that are hard to visualize.
resolves#20095
Pull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.