Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Moving RGBD parts to 3d#20013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alalek merged 150 commits intoopencv:nextfromsavuor:rgbd_to_3d
Aug 22, 2021
Merged

Moving RGBD parts to 3d#20013

alalek merged 150 commits intoopencv:nextfromsavuor:rgbd_to_3d
Aug 22, 2021

Conversation

@savuor
Copy link
Contributor

@savuorsavuor commentedApr 29, 2021•
edited
Loading

Pull Request Readiness Checklist

Connected PR in contrib repo:opencv/opencv_contrib#2936
Related to3D module

TODOs:

  • Fix builds
  • Fix bindings: now some bindings are turned off
  • MakeIntr class private, don't need to have it in public API
  • Fix bindings forVolume::resolution,Volume::pose,linemod::Template

TODOs for next PRs:

  • Add masks:
  • input mask for integrate
  • output mask for raycast
  • input masks for ICP

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@savuor
Copy link
ContributorAuthor

License notices should be applied properly.

Use PImpl in public headers.
Don't use legacy deprecated stuff.
Force 4 spaces for indentation.

Fixed everything, buildbot is green, any other edits to do?

Copy link
Member

@alalekalalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the update!

Please take a look on the comments about public headers.

@savuor
Copy link
ContributorAuthor

Fixed the comments and all the builds on buildbot, anything else rest?

Copy link
Member

@alalekalalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well done 👍

@alalekalalek merged commitbae9cef intoopencv:nextAug 22, 2021
chinhsuanwu added a commit to chinhsuanwu/opencv that referenced this pull requestAug 23, 2021
Merge pull requestopencv#20013 from savuor:rgbd_to_3d
@savuorsavuor deleted the rgbd_to_3d branchAugust 24, 2021 13:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alalekalalekalalek approved these changes

@vpisarevvpisarevAwaiting requested review from vpisarev

+1 more reviewer

@komakaikomakaikomakai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alalekalalek

Projects

None yet

Milestone

5.0-alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@savuor@alalek@komakai
[8]ページ先頭
©2009-2025 Movatter.jp