Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

different paddings in cvtColorTwoPlane() for biplane YUV420#19554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@amirtu
Copy link
Member

fixes#17036

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

@amirtu There is failed test in CI log:missing_check_17036. The test checks that function throws exception, if strides are different. You need to implement the test properly and rename the test according to its logic.

@asmorkalovasmorkalov added category: imgproc optimization pr: needs testNew functionality requires minimal tests set labelsFeb 18, 2021
@amirtuamirtu changed the titlewip: separate steps for image data planes in cvtColorTwoPlane()wip: separate steps for biplane YUV420 in cvtColorTwoPlane()Feb 18, 2021
@amirtuamirtu changed the titlewip: separate steps for biplane YUV420 in cvtColorTwoPlane()separate steps for biplane YUV420 in cvtColorTwoPlane()Feb 19, 2021
@amirtuamirtu changed the titleseparate steps for biplane YUV420 in cvtColorTwoPlane()different paddings in cvtColorTwoPlane() for biplane YUV420Feb 20, 2021
{
CV_INSTRUMENT_REGION();

const uchar* uv = src_data + src_step *static_cast<size_t>(dst_height);
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is the pointer arithmetics being done under dispatched branch of code by purpose?

@asmorkalovasmorkalov removed the pr: needs testNew functionality requires minimal tests set labelFeb 24, 2021
@asmorkalovasmorkalovforce-pushed theOCV-215_cvtColorTwoPlane_wrong_output_when_Y_Plane_Mat_has_step branch from0c861d8 toe6f2066CompareMarch 19, 2021 09:01
@asenyaev
Copy link
Contributor

jenkins cn please retry a build

@asmorkalovasmorkalovforce-pushed theOCV-215_cvtColorTwoPlane_wrong_output_when_Y_Plane_Mat_has_step branch frome6f2066 toe84fb22CompareSeptember 22, 2021 06:06
@asmorkalov
Copy link
Contributor

@alalek I fixed build issue for dispatch case and rebased the branch to current 3.4. Please take a look and merge the PR.

Comment on lines +149 to +152
CALL_HAL(cvtTwoPlaneYUVtoBGREx, cv_hal_cvtTwoPlaneYUVtoBGREx,
y_data, y_step, uv_data, uv_step, dst_data, dst_step, dst_width, dst_height, dcn, swapBlue, uIdx);

CV_CPU_DISPATCH(cvtTwoPlaneYUVtoBGR, (y_data, y_step, uv_data, uv_step, dst_data, dst_step, dst_width, dst_height, dcn, swapBlue, uIdx),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should have fallback on HAL code specialized fory_step == uv_step case.
Otherwise this patch introduces performance regressions (to see that, drop changes from the HAL implementations).

if (y_step == uv_step)    CALL_HAL(cvtTwoPlaneYUVtoBGR, cv_hal_cvtTwoPlaneYUVtoBGR, ...)

See discussion near removedCV_CheckEQ() for details (which is not resolved).

asmorkalov reacted with eyes emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed.

Copy link
Member

@alalekalalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you 👍

@alalekalalek merged commit86a5101 intoopencv:3.4Sep 22, 2021
@alalekalalek mentioned this pull requestSep 25, 2021
@alalekalalek mentioned this pull requestOct 15, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

@alalekalalekalalek approved these changes

Assignees

@asmorkalovasmorkalov

Projects

None yet

Milestone

3.4.16

Development

Successfully merging this pull request may close these issues.

4 participants

@amirtu@asmorkalov@asenyaev@alalek
[8]ページ先頭
©2009-2025 Movatter.jp