Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

G-API: Introduce streaming::desync and infer(ROI)#18673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
opencv-pushbot merged 1 commit intoopencv:masterfromdmatveev:dm/upstream_desync
Oct 29, 2020

Conversation

@dmatveev
Copy link
Contributor

@dmatveevdmatveev commentedOct 27, 2020
edited
Loading

This patch is mainly upstreaming of a long-live internal branch.
The functionality has been tested already in the "real world" scenarios.

  • desync() is a new (and for now, the only one) intrinsic
    which splits the graph execution into asynchronous parts
    when running in Streaming mode;

  • desync() makes no effect when compiling in Traditional mode;

  • Added tests on desync() working in various scenarios;

  • Extended GStreamingExecutor to support desync(); also extended
    GStreamingCompiled() with a new version of pull() returning a
    vector of optional values;

  • Fixed various issues with storing the type information & proper
    construction callbacks for GArray<> and GOpaque;

  • Introduced a new infer(Roi,GMat) overload with a sample;

  • Introduced an internal API for Islands to control fusion
    procedure (to fuse or not to fuse);

  • Introduced handleStopStream() callback for island executables;

  • Added GCompileArgs to metadata of the graph (required for other
    features).

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Macbuild_gapi_standalone:Linux x64=ade-0.1.1fbuild_gapi_standalone:Win64=ade-0.1.1fbuild_gapi_standalone:Mac=ade-0.1.1fbuild_gapi_standalone:Linux x64 Debug=ade-0.1.1fXbuild_image:Custom=centos:7Xbuildworker:Custom=linux-1build_gapi_standalone:Custom=ade-0.1.1fbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04build_image:Custom Win=openvino-2020.3.0build_image:Custom Mac=openvino-2020.3.0test_modules:Custom=gapitest_modules:Custom Win=gapitest_modules:Custom Mac=gapibuildworker:Custom=linux-1# disabled due high memory usage: test_opencl:Custom=ONtest_opencl:Custom=OFFtest_bigdata:Custom=1test_filter:Custom=*

@dmatveevdmatveev added this to the4.5.1 milestoneOct 27, 2020
@dmatveevdmatveev self-assigned thisOct 27, 2020
@dmatveevdmatveevforce-pushed thedm/upstream_desync branch 2 times, most recently frome8a57aa to47d3275CompareOctober 28, 2020 10:37
@dmatveev
Copy link
ContributorAuthor

@TolyaTalamanov@rgarnov builds are green.

Let's have a look on this one more time and get it merged then

- desync() is a new (and for now, the only one) intrinsic  which splits the graph execution into asynchronous parts  when running in Streaming mode;- desync() makes no effect when compiling in Traditional mode;- Added tests on desync() working in various scenarios;- Extended GStreamingExecutor to support desync(); also extended  GStreamingCompiled() with a new version of pull() returning a  vector of optional values;- Fixed various issues with storing the type information & proper  construction callbacks for GArray<> and GOpaque;- Introduced a new infer(Roi,GMat) overload with a sample;- Introduced an internal API for Islands to control fusion  procedure (to fuse or not to fuse);- Introduced handleStopStream() callback for island executables;- Added GCompileArgs to metadata of the graph (required for other  features).
@dmatveev
Copy link
ContributorAuthor

@alalek@mshabunin review complete, required builds passed. Can you please merge it? We need to have this in our baseline before next Wed. Thanks!

auto ext = model_path.substr(sz - EXT_LEN);
std::transform(ext.begin(), ext.end(), ext.begin(), [](unsignedchar c){
returnstatic_cast<unsignedchar>(std::tolower(c));
});
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

so I know about cv::toLowerCase but let's address this in another MR (with a test on InferROI)

@alalekalalek assignedrgarnov and unassigneddmatveevOct 29, 2020
@opencv-pushbotopencv-pushbot merged commit691c3d1 intoopencv:masterOct 29, 2020
@dmatveev
Copy link
ContributorAuthor

Fantastic! Thanks!

@alalekalalek mentioned this pull requestNov 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rgarnovrgarnovrgarnov approved these changes

@TolyaTalamanovTolyaTalamanovTolyaTalamanov approved these changes

Assignees

@rgarnovrgarnov

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@dmatveev@TolyaTalamanov@rgarnov@opencv-pushbot@alalek

[8]ページ先頭

©2009-2025 Movatter.jp