Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
G-API: Introduce streaming::desync and infer(ROI)#18673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e8a57aa to47d3275Comparedmatveev commentedOct 28, 2020
@TolyaTalamanov@rgarnov builds are green. Let's have a look on this one more time and get it merged then |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
- desync() is a new (and for now, the only one) intrinsic which splits the graph execution into asynchronous parts when running in Streaming mode;- desync() makes no effect when compiling in Traditional mode;- Added tests on desync() working in various scenarios;- Extended GStreamingExecutor to support desync(); also extended GStreamingCompiled() with a new version of pull() returning a vector of optional values;- Fixed various issues with storing the type information & proper construction callbacks for GArray<> and GOpaque;- Introduced a new infer(Roi,GMat) overload with a sample;- Introduced an internal API for Islands to control fusion procedure (to fuse or not to fuse);- Introduced handleStopStream() callback for island executables;- Added GCompileArgs to metadata of the graph (required for other features).
47d3275 toca8bb8dComparedmatveev commentedOct 29, 2020
@alalek@mshabunin review complete, required builds passed. Can you please merge it? We need to have this in our baseline before next Wed. Thanks! |
| auto ext = model_path.substr(sz - EXT_LEN); | ||
| std::transform(ext.begin(), ext.end(), ext.begin(), [](unsignedchar c){ | ||
| returnstatic_cast<unsignedchar>(std::tolower(c)); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
so I know about cv::toLowerCase but let's address this in another MR (with a test on InferROI)
dmatveev commentedOct 29, 2020
Fantastic! Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
This patch is mainly upstreaming of a long-live internal branch.
The functionality has been tested already in the "real world" scenarios.
desync() is a new (and for now, the only one) intrinsic
which splits the graph execution into asynchronous parts
when running in Streaming mode;
desync() makes no effect when compiling in Traditional mode;
Added tests on desync() working in various scenarios;
Extended GStreamingExecutor to support desync(); also extended
GStreamingCompiled() with a new version of pull() returning a
vector of optional values;
Fixed various issues with storing the type information & proper
construction callbacks for GArray<> and GOpaque;
Introduced a new infer(Roi,GMat) overload with a sample;
Introduced an internal API for Islands to control fusion
procedure (to fuse or not to fuse);
Introduced handleStopStream() callback for island executables;
Added GCompileArgs to metadata of the graph (required for other
features).
Pull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.