Extract CoreGraphics conversion logics from ios_conversions.mm to apple_conversions.h, apple_conversions.mm (MatToCGImage(), CGImageToMat())
Simplify ios_conversions.mm
Add macosx_conversions.mm for macOS/AppKit (MatToNSImage(), NSImageToMat())
Add Mat+Conversions.h and Mat+Conversions.mm for macOS/AppKit

Usage example in Swift:
※ Don't forget to set the-all_load flag to "Other Linker Flags" in "Build Settings" when using!#17532

// CGImage to Matlet sourceMat = Mat(cgImage: cgImage, alphaExist: true)// NSImage to Matlet sourceMat = Mat(nsImage: nsImage, alphaExist: true)// Something to processlet grayMat = Mat()Imgproc.cvtColor(src: sourceMat, dst: grayMat, code: .COLOR_RGBA2GRAY)// Mat to CGImagelet cgImage = grayMat.toCGImage().takeRetainedValue() // or .takeUnetainedValue()// Mat to NSImagelet nsImage = grayMat.toNSImage()

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work

force_builders=Custom Macbuild_image:Custom Mac=osx_frameworkbuildworker:iOS=macosx-1

mtfrctl added3 commits

October 9, 2020 12:06

Extract CoreGraphics conversion logics from ios_conversions.mm to app…

f4d509c

…le_conversions.h, apple_conversions. Add macosx_conversions.mm

Add macosx.h

35e088b

Add Mat+Conversions.h and Mat+Conversions.mm

53d6340

mtfrctl mentioned this pull request

Oct 9, 2020

Mat conversions for macOS/AppKit#18546

Open

mtfrctl changed the title~~Mat conversions for macOS(AppKit)~~Mat conversions for macOS/AppKit

Oct 9, 2020

Delete duplicated declaration from apple_conversion.mm

5ce5a56

alalek reviewed

Oct 9, 2020

View reviewed changes

Copy link

Member

alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for contribution!

Please take a look on comments below.

modules/imgcodecs/include/opencv2/imgcodecs/macosx.h Outdated

		//
		//
		// License Agreement
		// For Open Source Computer Vision Library

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please use short license header:https://github.com/opencv/opencv/wiki/Coding_Style_Guide#file-structure

// This file is part of OpenCV project.// It is subject to the license terms in the LICENSE file found in the top-level directory// of this distribution and at http://opencv.org/license.html.

Copy link

ContributorAuthor

mtfrctlOct 9, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🙆‍♂️
42a685c

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for updates!
Please make similar update of license headers of new files in this PR.
Please remove empty first line in this file.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ae0ba08

modules/imgcodecs/include/opencv2/imgcodecs/macosx.hShow resolvedHide resolved

modules/imgcodecs/src/apple_conversions.h Outdated

		#import <AVFoundation/AVFoundation.h>
		#import <ImageIO/ImageIO.h>
		#include "opencv2/core.hpp"
		#include "precomp.hpp"

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

precomp.hpp

Please don't use this from header files. Move into .mm files instead

Copy link

ContributorAuthor

mtfrctlOct 9, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you. I moved it.
edfe785

modules/imgcodecs/include/opencv2/imgcodecs/macosx.h OutdatedShow resolvedHide resolved

modules/imgcodecs/src/apple_conversions.mm


		CGColorSpaceRef colorSpace;

		if (image.elemSize() == 1) {

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

.elemSize() =>.channels()

+CV_CheckDepth(image.depth(), CV_8U, ""); check on the first line.

OK, I see this code is just moved.

alalek reviewed

Oct 9, 2020

View reviewed changes

modules/imgcodecs/include/opencv2/imgcodecs/macosx.hShow resolvedHide resolved

mtfrctl added5 commits

October 9, 2020 18:33

Use short license header

42a685c

Add compile guard

57b9631

Delete unused imports

7e72d2f

Move precomp.hpp import from header to implementation

edfe785

Add macosx.h to skip headers

8b1cc75

mtfrctl requested a review fromalalek

October 9, 2020 11:50

mtfrctl mentioned this pull request

Oct 9, 2020

Objc binding#17165

Merged

5 tasks

mtfrctl added2 commits

October 10, 2020 12:50

Fix compile guard condition

7b668e4

Use short license header

ae0ba08

Copy link

Contributor

@mtfrctl thanks for this - this is a great feature.
I checked the code and everything looks fine.
I have tried it quickly - after I remembered to set-all_load in theOther Linker Flags of my project everything worked well.
👍

Copy link

ContributorAuthor

mtfrctl commentedOct 10, 2020•
edited
Loading

@komakai Thank you! Regarding the flag, people who come to check here will also check these@komakai and@treastrain conversations (#17532 #18023), but it would be nice in the future so that it can be used immediately without being aware of these things ⭐

Remove commented out unused code

c4177c1

Copy link

ContributorAuthor

mtfrctl commentedOct 11, 2020•
edited
Loading

@alalek By the way, I would like to add the following method tomodules/core/misc/objc/common/Mat.mm (and .h) for more flexibility, is it okay to include it in this PR, or is it better to separate it into another PR?

- (unsigned char*)dataPtr {    return _nativePtr->data;}

Copy link

Member

alalek commentedOct 11, 2020

If there is no strong dependency between patches, then separate PR is better.

Copy link

ContributorAuthor

mtfrctl commentedOct 11, 2020•
edited
Loading

@alalek I created a PR separately here#18566. I'm sorry to bother you, but I'd be happy if you could check it. 🙏

alalek approved these changes

Oct 14, 2020

View reviewed changes

Copy link

Member

alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mtfrctl Thank you for contribution 👍

@komakai Thank you for review!

alalek merged commit7de1891 intoopencv:master

Oct 14, 2020

mtfrctl deleted the objc-conversions-macosx branch

October 15, 2020 06:13

Copy link

Contributor

komakai commentedOct 15, 2020

@mtfrctl keep the contributions coming!

This was referencedNov 18, 2020

Add apple_conversions to framework buildsRightpoint/opencv#5

Closed

Expose CGImage <-> Mat conversion for iOS platforms#18855

Merged

alalek mentioned this pull request

Nov 27, 2020

Merge 4.x#18951

Merged

a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request

Mar 30, 2023

Merge pull requestopencv#18547from mtfrctl:objc-conversions-macosx

44a8b5a

Mat conversions for macOS/AppKit* Extract CoreGraphics conversion logics from ios_conversions.mm to apple_conversions.h, apple_conversions. Add macosx_conversions.mm* Add macosx.h* Add Mat+Conversions.h and Mat+Conversions.mm* Delete duplicated declaration from apple_conversion.mm* Use short license header* Add compile guard* Delete unused imports* Move precomp.hpp import from header to implementation* Add macosx.h to skip headers* Fix compile guard condition* Use short license header* Remove commented out unused code

Labels

category: imgcodecs feature platform: ios/osx

Movatterモバイル変換

Uh oh!

Mat conversions for macOS/AppKit#18547

Mat conversions for macOS/AppKit#18547

Uh oh!

Conversation

mtfrctl commentedOct 9, 2020• edited by alalekLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

alalekOct 9, 2020

Choose a reason for hiding this comment

Uh oh!

mtfrctlOct 9, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalekOct 9, 2020

Choose a reason for hiding this comment

Uh oh!

mtfrctlOct 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alalekOct 9, 2020

Choose a reason for hiding this comment

Uh oh!

mtfrctlOct 9, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alalekOct 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

komakai commentedOct 10, 2020

Uh oh!

mtfrctl commentedOct 10, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

mtfrctl commentedOct 11, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

alalek commentedOct 11, 2020

Uh oh!

mtfrctl commentedOct 11, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

komakai commentedOct 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mtfrctl commentedOct 9, 2020•
edited by alalek
Loading

mtfrctlOct 9, 2020•
edited
Loading

mtfrctlOct 9, 2020•
edited
Loading

mtfrctl commentedOct 10, 2020•
edited
Loading

mtfrctl commentedOct 11, 2020•
edited
Loading

mtfrctl commentedOct 11, 2020•
edited
Loading