Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CUDA: drop support of old CC#17478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
opencv-pushbot merged 1 commit intoopencv:3.4fromtomoaki0705:dropOldCC
Aug 3, 2020

Conversation

@tomoaki0705
Copy link
Contributor

@tomoaki0705tomoaki0705 commentedJun 5, 2020•
edited by alalek
Loading

resolves#16649

  • update minimum requirement of CUDA to 8.0
  • remove deprecated version checks

Still, this PR is open for discussion.
Supporting different CUDA based on branch is one solution.
Updating CUDA 8.0 is also another point to discuss.
It's still possible to build for old CC, by specifyingCUDA_ARCH_BIN manually at cmake stage

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custombuildworker:Custom=linux-4build_image:Custom=ubuntu-cuda:18.04

@tomoaki0705
Copy link
ContributorAuthor

There are many aspects to discuss on this PR.

  • master/3.4 branch
    • May be we can keep the support situation for 3.4, so porting this branch only to master branch makes sense
  • CUDA version
  • Jetson TK1 support
    • If I remember correctly, one of the build machine was based on Jetson TK1.
    • Dropping TK1 might be too early ?
    • If we upgrade to 8.0, user can't enable CUDA feature on TK1, since it only has old CUDA 6.5
  • sm_50
    • Already, there are notice about dropping support sm_50
    • Even we wipe out from the default list, user can specify the CC withCUDA_ARCH_BIN option, so there is a way to use it.

@asmorkalov
Copy link
Contributor

@tomoaki0705 Thanks for the started discussion you touched the same items that I want to bring. I discussed the proposal with@alalek and@vpisarev and outcome is the following:

Key ideas

  • It's not good idea to drop support in minor releases and it's better to do it with major change. We propose to presume support on current level till 5.0.
  • OpenCV 3.4 branch is merged to master weekly or be-weekly and we ask people to propose bug fixes to 3.4. Major changes in build infrastructure leads to merge conflicts and it's better to introduce changes to 3.4 first.
  • It's reasonable to drop CC 1.x and 2.x, but 3.x is still in use and it'll be great to support Jetson TK1.

Technical proposal

  • Exclude not CCs fromCUDA_ARCH_BIN andCUDA_ARCH_PTX defaults. and propose only modern arches.
  • Introduce extra cmake flag like `ENABLE_DEPRICATED_CUDA_CC" to turn them on or some solution like that to mark old stuff deprecated and enable it with extra options.
  • Stay with CUDA 6.5 as baseline, see TK1.
  • Enable new functionality for modern CUDA/CC only, if it's needed for DNN.

@tomoaki0705
Copy link
ContributorAuthor

Sorry for the late reply.
I now understand the key idea of what you meant.
Let me update the PR

asmorkalov reacted with thumbs up emoji

@tomoaki0705tomoaki0705force-pushed thedropOldCC branch 3 times, most recently from80ff6e6 toba298d1CompareJune 18, 2020 12:57
@tomoaki0705
Copy link
ContributorAuthor

@asmorkalov , I've updated the PR.
Please let me know if this PR is aligned with your thought.

@tomoaki0705tomoaki0705force-pushed thedropOldCC branch 2 times, most recently from2e66ff4 to9213671CompareJune 21, 2020 21:57
  * keep it possible to build for old CC  * make sure old generations don't come up for the choice  * remove related version check of old one
Copy link
Member

@alalekalalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me 👍

@asmorkalovasmorkalov removed the RFC labelAug 3, 2020
@opencv-pushbotopencv-pushbot merged commitce74285 intoopencv:3.4Aug 3, 2020
@tomoaki0705tomoaki0705 deleted the dropOldCC branchAugust 3, 2020 14:31
@alalekalalek mentioned this pull requestAug 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

@alalekalalekalalek approved these changes

Assignees

@asmorkalovasmorkalov

Labels

category: build/installcategory: gpu/cuda (contrib)OpenCV 4.0+: moved to opencv_contribfutureThis issue can't be fixed during restrictions of the compatibility requirements

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

4 participants

@tomoaki0705@asmorkalov@alalek@opencv-pushbot
[8]ページ先頭
©2009-2025 Movatter.jp