NotificationsYou must be signed in to change notification settings
Fork56.4k
Star85.3k

Added Dashed Rectangle feature in Drawing.cpp#16880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

VisheshKhosla wants to merge3 commits intoopencv:masterfromVisheshKhosla:feature

Closed

Added Dashed Rectangle feature in Drawing.cpp#16880

VisheshKhosla wants to merge3 commits intoopencv:masterfromVisheshKhosla:feature

Conversation

Copy link

VisheshKhosla commentedMar 22, 2020•
edited
Loading

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under OpenCV (BSD) License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

VisheshKhosla added2 commits

March 23, 2020 03:10

Update drawing.cpp

59ff4a4

void dash_rectangle(InputOutputArray _img, Point pt1, Point pt2,    const Scalar& color, int thickness = 1,    int lineType = 8, int shift = 0,int gap=5) Where the gap is the distance between the dashes.

Merge pull request#1from VisheshKhosla/VisheshKhosla-patch-1-1

c05077f

Update drawing.cpp

VisheshKhosla changed the title~~Feature~~Added Dashed Rectangle feature in Drawing.cpp

Mar 22, 2020

Copy link

Author

VisheshKhosla commentedMar 22, 2020

void dash_rectangle(InputOutputArray _img, Point pt1, Point pt2,
const Scalar& color, int thickness = 1,
int lineType = 8, int shift = 0,int gap=5)
Where the gap is the distance between the dashes.

Copy link

Author

VisheshKhosla commentedMar 22, 2020

It shows that docs have failed the merging process.Can i know more about this?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please use enum valueshttps://docs.opencv.org/master/d6/d6e/group__imgproc__draw.html#gaf076ef45de481ac96e0ab3dc2c29a777 instead of int8

dkurt reviewed

Mar 23, 2020

View reviewed changes

modules/imgproc/src/drawing.cpp Outdated

		line(_img, v1, v1, color, thickness, lineType =8, shift =0);
		line(_img, v2, v2, color, thickness, lineType =8, shift =0);
		line(_img, v3, v3, color, thickness, lineType =8, shift =0);
		line(_img, v4, v4, color, thickness, lineType =8, shift =0);

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Drawing points as lines is not a good idea due it's not convenient if this line has length or not. So nothing can be drawn as well. I would like to recommend to replace to filled rectangle

asmorkalov added the category: imgproc label

Mar 24, 2020

asmorkalov added the pr: Discussion Required label

Apr 9, 2020

asmorkalov requested changes

Apr 9, 2020

View reviewed changes

modules/imgproc/src/drawing.cpp OutdatedShow resolvedHide resolved

Copy link

Contributor

asmorkalov commentedApr 9, 2020

@VisheshKhosla do you plan to finish the PR in mean time?

asmorkalov added pr: needs docs

Please update corresponding documentation

pr: needs testNew functionality requires minimal tests set labels

Apr 9, 2020

Copy link

Author

VisheshKhosla commentedApr 9, 2020

@VisheshKhosla do you plan to finish the PR in mean time?

Yes sure,i am really sorry for the delay.

asmorkalov assignedvpisarev

Apr 10, 2020

Have made lineType and shift same as the function parameters.

cc2fa84

Copy link

Contributor

asmorkalov commentedApr 15, 2020

@vpisarev What is your opinion?

Copy link

Contributor

vpisarev commentedApr 23, 2020

@VisheshKhosla, thank you for the contribution! I think, we need to carefully design and then implement this functionality with extended drawing primitives. Just adding functions one-by-one is not a good idea, that will result in a bloated and inconsistent API. Please, look at the following evolution proposal:https://github.com/opencv/opencv/wiki/OE-24.-Module-HighGUI. I've added there items about dashed figures. Let me close this PR for now, and you are welcome to the discussion thread about the evolution proposal (#11019). Someone needs to compose a detailed API proposal, then it should be discussed and then we should start working on the implementation.