Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix issue #6450#15464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
opencv-pushbot merged 2 commits intoopencv:3.4fromtallestorange:3.4
Feb 3, 2020
Merged

Fix issue #6450#15464

opencv-pushbot merged 2 commits intoopencv:3.4fromtallestorange:3.4
Feb 3, 2020

Conversation

@tallestorange
Copy link
Contributor

@tallestorangetallestorange commentedSep 5, 2019•
edited by alalek
Loading

resolves#6450

Fix issue#6450

I changed a logic of cv::VideoCapture().
Because cv::VideoCapture::get returns wrong value and cv::VideoCapture cannot set value.
Transplanting cv::VideoCapture()'s logic of macOS, this problem can be fixed.

allow_multiple_commits=1

@asmorkalov
Copy link
Contributor

@tallestorange Thanks for you contribution. The patch introduces several build warnings on iOS configuration, could you look at it:

/Volumes/build-storage/build/precommit_ios/3.4/opencv/modules/videoio/src/cap_avfoundation.mm:1055:68: warning: values of type 'OSType' should not be used as format arguments; add an explicit cast to 'unsigned int' instead [-Wformat]1 warning generated./Volumes/build-storage/build/precommit_ios/3.4/opencv/modules/videoio/src/cap_avfoundation.mm:1055:68: warning: values of type 'OSType' should not be used as format arguments; add an explicit cast to 'unsigned int' instead [-Wformat]1 warning generated./Volumes/build-storage/build/precommit_ios/3.4/opencv/modules/videoio/src/cap_avfoundation.mm:1055:68: warning: values of type 'OSType' should not be used as format arguments; add an explicit cast to 'unsigned int' instead [-Wformat]1 warning generated.

CI link:https://pullrequest.opencv.org/buildbot/builders/precommit_ios/builds/20885/steps/build%20framework/

@VadimLevin
Copy link
Contributor

Hello,@tallestorange. Just gently reminder. Do you have any chance to complete this PR and fix introduced warnings?

@asmorkalovasmorkalov added pr: Discussion Required Hackathonhttps://opencv.org/opencv-hackathon-starts-next-week/ labelsJan 30, 2020
Copy link
Contributor

@vpisarevvpisarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

warning is fixed; can merge it, I think 👍

@opencv-pushbotopencv-pushbot merged commit1740225 intoopencv:3.4Feb 3, 2020
@alalekalalek mentioned this pull requestFeb 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vpisarevvpisarevvpisarev approved these changes

Assignees

@vpisarevvpisarev

Labels

Hackathonhttps://opencv.org/opencv-hackathon-starts-next-week/platform: ios/osx

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

6 participants

@tallestorange@asmorkalov@VadimLevin@vpisarev@opencv-pushbot@alalek
[8]ページ先頭
©2009-2025 Movatter.jp