Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix oss-fuzz bugs 391934081 and 392318892#26854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 2 commits intoopencv:4.xfromvrabaud:png_leak
Jan 31, 2025

Conversation

@vrabaud
Copy link
Contributor

@vrabaudvrabaud commentedJan 29, 2025•
edited by asmorkalov
Loading

  • fix a potential overflow in x0+w0
  • use the proper function to deal with background color to deal with all cases of the spec
  • use BGR layout for APNG background color

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@vrabaud
Copy link
ContributorAuthor

I also switched the alpha to no be transparent: it does not matter anyway as it is not included in the spec (it is a background color) but we might as well have the color be usable.

asmorkalov reacted with thumbs up emoji

@vrabaud
Copy link
ContributorAuthor

vrabaud commentedJan 29, 2025•
edited
Loading

Actually, I switched back to having alpha == 0: this is more consistent with thecv::Scalar API

asmorkalov reacted with thumbs up emoji

- fix a potential overflow in x0+w0- use the proper function to deal with background color to deal  with all cases of the spec
@asmorkalovasmorkalov merged commitc21d0ad intoopencv:4.xJan 31, 2025
30 of 31 checks passed
@asmorkalovasmorkalov mentioned this pull requestFeb 19, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull requestFeb 24, 2025
Fix oss-fuzz bugs 391934081 and 392318892opencv#26854- fix a potential overflow in x0+w0- use the proper function to deal with background color to deal with all cases of the spec- use BGR layout for APNG background color### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [x] I agree to contribute to the project under Apache 2 License.- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [x] The PR is proposed to the proper branch- [x] There is a reference to the original bug report and related work- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable      Patch to opencv_extra has the same branch name.- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

+1 more reviewer

@sturkmen72sturkmen72sturkmen72 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@asmorkalovasmorkalov

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vrabaud@asmorkalov@sturkmen72
[8]ページ先頭
©2009-2025 Movatter.jp