Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

solvePnPRansac implementation for Fisheye camera model#26669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 2 commits intoopencv:4.xfromGouMinghao:4.x
Jan 24, 2025

Conversation

@GouMinghao
Copy link
Contributor

@GouMinghaoGouMinghao commentedDec 24, 2024•
edited by asmorkalov
Loading

Related:#25028

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@GouMinghao
Copy link
ContributorAuthor

@asmorkalov@vpisarev
First of all, Merry Christmas!
Hi, this is the first time that I am tring to contribute to opencv, Could you have a look on this PR and give me some advice.
I just implement solvePnPRansac similar to#25028.
Unit test is added and everything seems to be correct.
Thanks a lot.

@GouMinghao
Copy link
ContributorAuthor

@asmorkalov There are some errors in the CI but seem not to be related to this PR, could you have a look on this?

asmorkalov reacted with eyes emoji

@asmorkalovasmorkalov self-requested a reviewJanuary 6, 2025 08:25
@GouMinghao
Copy link
ContributorAuthor

@asmorkalov Thank you for your review. The related problems have been addressed.
You may check it again.

@asmorkalovasmorkalov self-assigned thisJan 24, 2025
@asmorkalovasmorkalov added this to the4.12.0 milestoneJan 24, 2025
@asmorkalovasmorkalov merged commit9bb01e7 intoopencv:4.xJan 24, 2025
27 of 31 checks passed
@asmorkalovasmorkalov mentioned this pull requestFeb 19, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull requestFeb 24, 2025
solvePnPRansac implementation for Fisheye camera modelopencv#26669Related:opencv#25028### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [x] I agree to contribute to the project under Apache 2 License.- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [x] The PR is proposed to the proper branch- [ ] There is a reference to the original bug report and related work- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable      Patch to opencv_extra has the same branch name.- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

Assignees

@asmorkalovasmorkalov

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@GouMinghao@asmorkalov
[8]ページ先頭
©2009-2025 Movatter.jp