Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
Update haveCUDA() to detect CUDA support at runtime#26164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6e99bd0 to0cf42b0CompareContributorAuthor
CSBVision commentedOct 30, 2024
Is there any comment regarding this PR? We would like to work on some follow-up improvements, still this makes not too much sense as long as this patch isn't merged... |
asmorkalov approved these changesDec 26, 2024
asmorkalov approved these changesDec 26, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor improvement regarding the CUDA support is required. Currently,
haveCUDA()is equivalent to using theHAVE_CUDAdefine. However, existing code combines both checks, which implies that it is intended to do a runtime instead of a compile time check. For example:opencv/modules/dnn/src/net_impl.cpp
Line 173 inf503890
Instead, we should use a runtime check in
haveCUDA(), similar tohaveVulkan(). Doing so, we can use CUDA by default whenever available by settingOPENCV_DNN_BACKEND_DEFAULT = DNN_BACKEND_CUDA, cf.#25112. The feature is implemented by simply checking for a valid CUDA device usingcudaGetDevice()and saving its return value such that this function is only called once.Pull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.