Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

imgproc: use double to determine whether the corners points are within src#26022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 6 commits intoopencv:4.xfromKumataro:fix26016
Aug 23, 2024

Conversation

@Kumataro
Copy link
Contributor

@KumataroKumataro commentedAug 13, 2024•
edited
Loading

close#26016
Relatedopencv/opencv_contrib#3778

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@KumataroKumataro marked this pull request as draftAugust 13, 2024 00:41
Copy link
Contributor

@opencv-alalekopencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

relates#24527

@KumataroKumataro changed the titleimgproc: use float32 to determine whether the corners points are within srcimgproc: use double to determine whether the corners points are within srcAug 14, 2024
@KumataroKumataro marked this pull request as ready for reviewAugust 14, 2024 12:28
@Kumataro
Copy link
ContributorAuthor

Kumataro commentedAug 14, 2024•
edited
Loading

It seems that CI doesn't work well. Is there anything I can help ?

I had been tried to re-run CI/CD with new git commit and push,
CI For Linux64 (https://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/108564 ) starts firstinit step, but doest not finished and does not conitue to next steps.

--- Added comment
I'm sorry I didn't notice to make pull-request on opencv-contrib. I created.opencv/opencv_contrib#3778
However I think it seems not a reason ...

opencv-alalek reacted with thumbs up emoji

boolempty()const;

//! conversion to another data type
template<typename _Tp2>operator Rect_<_Tp2>()const;
Copy link
Contributor

@opencv-alalekopencv-alalekAug 15, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Did you tryexplicit for conversion operator instead? (to avoid unexpected conversions)

(since C++11:https://en.cppreference.com/w/cpp/language/cast_operator )

Copy link
ContributorAuthor

@KumataroKumataroAug 16, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Did you try explicit for conversion operator instead? (to avoid unexpected conversions)

I think it is not easy, becausecv::Point andcv::Rect is used for drawing functions inimgproc, so there are many side-effetcs not only OpenCV library but also user-applications. (I would like to do that if possible...)

Following are trial codes, but it doesn't include some modules (cuda*, hdf, ...).

@asmorkalovasmorkalov added this to the4.11.0 milestoneAug 23, 2024
@asmorkalovasmorkalov self-assigned thisAug 23, 2024
@asmorkalovasmorkalov merged commita3bdbf5 intoopencv:4.xAug 23, 2024
@asmorkalovasmorkalov mentioned this pull requestAug 27, 2024
thewoz pushed a commit to CobbsLab/OPENCV that referenced this pull requestFeb 13, 2025
Imgproc: use double to determine whether the corners points are within srcopencv#26022closeopencv#26016Relatedopencv/opencv_contrib#3778### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [x] I agree to contribute to the project under Apache 2 License.- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [x] The PR is proposed to the proper branch- [x] There is a reference to the original bug report and related work- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable      Patch to opencv_extra has the same branch name.- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@opencv-alalekopencv-alalekopencv-alalek left review comments

@asmorkalovasmorkalovasmorkalov approved these changes

Assignees

@asmorkalovasmorkalov

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

cv2.error: in function 'cv::cornerSubPix'

3 participants

@Kumataro@asmorkalov@opencv-alalek
[8]ページ先頭
©2009-2025 Movatter.jp