Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
Added xxxApprox overloads for YUV color conversions in HAL and AlgorithmHint to cvtColor#25932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…hmHint to cvtColor.
asmorkalov commentedJul 18, 2024
Perf statistics for Jetson tk1 (ARMv7 NEON) and jetson orin: |
| @param isCbCr if set to true write output in YCbCr format | ||
| Convert from BGR, RGB, BGRA or RGBA to YUV or YCbCr. | ||
| */ | ||
| inlineinthal_ni_cvtBGRtoYUVApprox(const uchar * src_data,size_t src_step, uchar * dst_data,size_t dst_step,int width,int height,int depth,int scn,bool swapBlue,bool isCbCr) {return CV_HAL_ERROR_NOT_IMPLEMENTED; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why 'Approx' is in the function name? Why not pass algorithm hint as a parameter?
asmorkalovJul 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The existing API is already used in 3rd party HAL like Carotene, KleidiCV and some other. So we need to in
introduce new API anyway. The solution just follows current HAL design.
asmorkalov commentedAug 6, 2024
@opencv-alalek Could you update ABI complience checker on BuildBot? |
Added xxxApprox overloads for YUV color conversions in HAL and AlgorithmHint to cvtColoropencv#25932The xxxApprox to implement HAL functions with less bits for arithmetic of FP.The hint was introduced inopencv#25792 andopencv#25911### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [x] I agree to contribute to the project under Apache 2 License.- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [x] The PR is proposed to the proper branch- [x] There is a reference to the original bug report and related work- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.- [x] The feature is well documented and sample code can be built with the project CMake
Added xxxApprox overloads for YUV color conversions in HAL and AlgorithmHint to cvtColoropencv#25932The xxxApprox to implement HAL functions with less bits for arithmetic of FP.The hint was introduced inopencv#25792 andopencv#25911### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [x] I agree to contribute to the project under Apache 2 License.- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [x] The PR is proposed to the proper branch- [x] There is a reference to the original bug report and related work- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.- [x] The feature is well documented and sample code can be built with the project CMake
Uh oh!
There was an error while loading.Please reload this page.
The xxxApprox to implement HAL functions with less bits for arithmetic of FP.
The hint was introduced in#25792 and#25911
Pull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.