Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

core: add v_erf#25872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asmorkalov merged 3 commits intoopencv:4.xfromfengyuentau:core/v_erf
Jul 5, 2024
Merged

core: add v_erf#25872

asmorkalov merged 3 commits intoopencv:4.xfromfengyuentau:core/v_erf
Jul 5, 2024

Conversation

@fengyuentau
Copy link
Member

This patch adds v_erf, which is needed by#25147.

Pull Request Readiness Checklist

See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Linux AVX2

@fengyuentau
Copy link
MemberAuthor

There is one small problem. There are several coefficients that are also needed by non-vetorized version. Do they need to be shared across core and dnn module? Or we just keep two copies of them in different files.

@asmorkalov
Copy link
Contributor

I propose to make copies and in vectorized version put reference to the flat origin.

fengyuentau reacted with thumbs up emoji

@asmorkalov
Copy link
Contributor

modules/core/include/opencv2/core/hal/intrin_cpp.hpp:767: trailing whitespace.

@asmorkalovasmorkalov merged commitd30b945 intoopencv:4.xJul 5, 2024
@fengyuentaufengyuentau deleted the core/v_erf branchJuly 6, 2024 15:41
@opencv-alalek
Copy link
Contributor

There is regression detected by weekly build:https://pullrequest.opencv.org/buildbot/builders/4_x_noICV-win32-vc14/builds/100083

@opencv-alalekopencv-alalek removed their request for reviewJuly 8, 2024 07:48
@asmorkalovasmorkalov mentioned this pull requestJul 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@asmorkalovasmorkalovasmorkalov approved these changes

@vpisarevvpisarevAwaiting requested review from vpisarev

Assignees

No one assigned

Projects

Status: Done

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@fengyuentau@asmorkalov@opencv-alalek
[8]ページ先頭
©2009-2025 Movatter.jp