Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork56.4k
Added screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization.#24869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…. Fixed JavaCamera2View initialization
| } | ||
| Log.i(LOGTAG,"Opening camera: " +mCameraID); | ||
| manager.openCamera(mCameraID,mStateCallback,mBackgroundHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Moved camera starting here, because preview size should be defined before camera start
| mCaptureSession.close(); | ||
| mCaptureSession =null; | ||
| } | ||
| createCameraPreviewSession(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is already a createCameraPreviewSession call in onOpened camera callback.
modules/java/generator/android-21/java/org/opencv/android/JavaCamera2View.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
asmorkalov commentedJan 17, 2024
@alexlyulkov I do not see preview with Pixel8 in Tutorial 4. Just black screen with text status in corner. |
asmorkalov commentedJan 17, 2024
Tutorial1-Camera-Preview works with all back-ends JavaCameraView, Java2CameraView and NativeCameraView with rotation. Please ignore the previous comment on Tutorial4. The sample does not work without the patch. It should be fixed separately. |
| android.hardware.Camera.CameraInfoinfo =newandroid.hardware.Camera.CameraInfo(); | ||
| android.hardware.Camera.getCameraInfo(localCameraIndex,info); | ||
| intframeRotation =getFrameRotation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like you can re-use CameraInfo from cameras iteration when camera is selected.
modules/java/generator/android/java/org/opencv/android/JavaCameraView.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
modules/java/generator/android-24/java/org/opencv/android/NativeCameraView.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
asmorkalov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
…ew-rotateAdded screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization.opencv#24869Added automatic image rotation to JavaCamera2View and NativeCameraView so the video preview was matched with screen orientation.Fixed double preview initialization bug in JavaCamera2View.Added proper cameraID parsing to NativeCameraView similar to JavaCameraView### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [x] I agree to contribute to the project under Apache 2 License.- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [x] The PR is proposed to the proper branch- [ ] There is a reference to the original bug report and related work- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.- [x] The feature is well documented and sample code can be built with the project CMake
Added automatic image rotation to JavaCamera2View and NativeCameraView so the video preview was matched with screen orientation.
Fixed double preview initialization bug in JavaCamera2View.
Added proper cameraID parsing to NativeCameraView similar to JavaCameraView
Pull Request Readiness Checklist
See details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.