- Notifications
You must be signed in to change notification settings - Fork2.2k
make exec.fifo can be safety read#4932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
42a0831 to640f468Comparecyphar commentedOct 14, 2025
We need to be quite careful around changing this code, as there is a lot of history behind how we ended up with this fairly ugly FIFO solution. The signalling model we have takes advantage of the fact that We used to use signals and switched to the FIFO because of lots of issues with that model (signal coalescing and pid1 has special signal semantics). That being said, I wonder if
This seems likeA Very Bad Idea ™️ -- unix sockets are not protected by |
ningmingxiao commentedOct 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I can't prevent user bind /var/run into container. I find crun start will write data into the fifo. may be we can refer it. |
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
Uh oh!
There was an error while loading.Please reload this page.
some people read-only mount /var/run into container,some process will read /run/runc/id/exec.fifo (for example antivirus apps) it will cause runc start failed.
after this commit /run/runc/id/exec.fifo has a lower risk of being misread even user doesn't ro bind /var/run into container.@kolyshkin@cyphar