Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow shared mounts by default#4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
evanphx wants to merge1 commit intoopencontainers:main
base:main
Choose a base branch
Loading
frommirendev:evanphx/b-shared

Conversation

@evanphx
Copy link
Contributor

@evanphxevanphx commentedFeb 27, 2025•
edited
Loading

The current behavior disallows any mount having (r)shared on it because by default, the root is set with MS_SLAVE|MS_REC, which disallows sub-dirs from having a different propagation.

Projects have been working around this by setting the RootfsPropogation to "shared", to override the default
(https://github.com/containerd/nerdctl/blob/main/pkg/mountutil/mountutil_linux.go#L185-L193).

This patch makes a reasonable attempt to make the functionality work without touching RootfsPropogation.

The current behavior disallows any mount have (r)shared on it because bydefault, the root is set with MS_SLAVE, which disallows sub-dirs fromhaving a different propagation.Projects have been working around this by setting the RootfsPropogationto "shared", to override the default(https://github.com/containerd/nerdctl/blob/main/pkg/mountutil/mountutil_linux.go#L185-L193).This patch makes a reasonable attempt to make the functionality workwithout touching RootfsPropogation.Signed-off-by: Evan Phoenix <evan@phx.io>
@evanphx
Copy link
ContributorAuthor

Looking at the code I've edited, the code resets it to PRIVATE below. Can someone chime in on what the code setting to SLAVE is meant to do? Totally likely my change isn't right because I'm not sure I understand what the purpose is of setting SLAVE is.

@rata
Copy link
Member

rata commentedApr 2, 2025•
edited
Loading

Just curious, why not set the propagation you want for the rootfs in the config.json, as nerdctl is doing in the link you point?

@rata
Copy link
Member

rata commentedApr 2, 2025

Can someone chime in on what the code setting to SLAVE is meant to do?

I guess@kolyshkin or@cyphar are the right persons to answer this

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evanphx@rata
[8]ページ先頭
©2009-2025 Movatter.jp