- Notifications
You must be signed in to change notification settings - Fork2.2k
Remove redundant function (needs Go >= 1.23)#4387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Tom Godkin <tomgodkin@pm.me>
BooleanCat commentedAug 30, 2024
I'm guessing you follow the same support policy for Go versions as the language itself? (i.e. this minor and the previous) |
AkihiroSuda commentedAug 30, 2024
Yes, so we still have to support Go 1.22 |
BooleanCat commentedAug 30, 2024
@AkihiroSuda understood, I'll leave this open until 1.24 or if you want to close I'll open another when it's released. |
octavio12345300 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
listo
AkihiroSuda commentedJul 17, 2025
Needs rebase |
Make use of Go 1.23's news
mapsandslicesiterators to replace a hand-crafted map key sorter.This relies on Go 1.23 being the minimum version - once it's updaded in
go.modI'll modify this commit to remove my change togo.mod.