NotificationsYou must be signed in to change notification settings
Fork910
Star3.6k

Commit7c058c6

committed

Prevent negative zero from being created via BN bit functions.

Both BN_clear_bit() and BN_mask_bits() can create zero values - in bothcases ensure that the negative sign is correctly handled if the valuebecomes zero.Thanks to Guido Vranken for providing a reproducer.Fixes oss-fuzz #67901ok tb@

1 parented75954 commit7c058c6Copy full SHA for 7c058c6

File tree

1 file changed

-1

lines changed

lib/libcrypto/bn
- bn_lib.c

1 file changed

-1

lines changed

`‎lib/libcrypto/bn/bn_lib.c‎`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* $OpenBSD: bn_lib.c,v 1.90 2023/07/28 10:35:14 tb Exp $ */`
	`1`	`+/* $OpenBSD: bn_lib.c,v 1.91 2024/04/15 14:35:25 jsing Exp $ */`
`2`	`2`	`/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)`
`3`	`3`	`* All rights reserved.`
`4`	`4`	`*`
`@@ -438,6 +438,9 @@ BN_clear_bit(BIGNUM *a, int n)`
`438`	`438`
`439`	`439`	`a->d[i] &= (~(((BN_ULONG)1) <<j));`
`440`	`440`	`bn_correct_top(a);`
	`441`	`+`
	`442`	`+BN_set_negative(a,a->neg);`
	`443`	`+`
`441`	`444`	`return (1);`
`442`	`445`	`}`
`443`	`446`	`LCRYPTO_ALIAS(BN_clear_bit);`
`@@ -476,6 +479,9 @@ BN_mask_bits(BIGNUM *a, int n)`
`476`	`479`	`a->d[w] &= ~(BN_MASK2 <<b);`
`477`	`480`	`}`
`478`	`481`	`bn_correct_top(a);`
	`482`	`+`
	`483`	`+BN_set_negative(a,a->neg);`
	`484`	`+`
`479`	`485`	`return (1);`
`480`	`486`	`}`
`481`	`487`	`LCRYPTO_ALIAS(BN_mask_bits);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7c058c6

File tree

1 file changed

1 file changed

`‎lib/libcrypto/bn/bn_lib.c‎`

0 commit comments