Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enum with Root Types Filtering Recursive Reference#2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ParkerVR wants to merge1 commit intoopenapi-ts:main
base:main
Choose a base branch
Loading
fromParkerVR:main

Conversation

ParkerVR
Copy link

@ParkerVRParkerVR commentedJul 14, 2025
edited
Loading

Changes

Using the --enum and --root-types in combination causes recursive reference to enum types used in schemas, breaking the file.
A few issues related:

#2099
#2341

How to Review

A specific combination of flags causes recursive imports, marked as patch since it seems incredibly unlikely anyone could successfully use this output in a production system. Had a custom in my project and was trying to use the flags instead, but the combined behavior broke me.https://github.com/Equal-IQ/api-model/blob/e99585b6244ac814ea1044f62333474a5857c3b8/Containers/generate.js

Checklist

  • Unit tests updated (CJS Test is broken before and after my change, unrelated)
  • []docs/ updated (if necessary) don't think any change is required, as this is a reasonable expected behavior
  • []pnpm run update:examples run (only applicable for openapi-typescript) no changes required to these, since the combination is not used for them

@ParkerVRParkerVR requested a review froma team as acode ownerJuly 14, 2025 08:40
@ParkerVRParkerVR requested a review fromdrwpowJuly 14, 2025 08:40
@netlifyNetlify
Copy link

netlifybot commentedJul 14, 2025
edited
Loading

👷 Deploy request foropenapi-ts pending review.

Visit the deploys page to approve it

NameLink
🔨 Latest commit3fabebe

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJul 14, 2025
edited
Loading

🦋 Changeset detected

Latest commit:3fabebe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
openapi-typescriptPatch
swr-openapiPatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ParkerVR added a commit to Equal-IQ/api-model that referenced this pull requestJul 14, 2025
@ParkerVR
Copy link
Author

I added some snapshot tests here since this change is a bit particular to CLI Flag Combination, though I guess it could be inlined instead like some of the other partial api spec examples. I'll leave it to maintainers to decide on that

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@drwpowdrwpowAwaiting requested review from drwpowdrwpow is a code owner automatically assigned from openapi-ts/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@ParkerVR

[8]ページ先頭

©2009-2025 Movatter.jp