Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork552
feat(openapi-react-query): add prefixQueryKey option#2357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👷 Deploy request foropenapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit:1f048dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means?Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RobertBjorklundDev commentedJul 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Awesome that this is on the way, I'm facing the same problem right now in my code and the only good option is to have an easy way of prefixing the queryKeys for a specific client! |
@htunnicliff@kerwanp Please give me any kind of comments. What’s your first impression of this PR? Are there any immediate concerns? Would you prefer to explore a different direction? Even if you’re still thinking it through, it’d be great if you could share your thoughts. |
Background
Close#1979.
Current openapi-react-query has a potential issue because
useQuery
calls from different clients are assigned the same key, even though they're querying different endpoints.For example:
Here, both queries receive the same key, even though they are querying different sources.
This try to resolve the problem.
Changes
prefixQueryKey
parameter to differentiate cache identities.How to Review
unknown
type.See
packages/openapi-react-query/test/index.test.tsx:270
, and feel free to leave a comment if you have any other thoughts.Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)