Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(transform): avoid duplicate enum declaration when using root types with no prefix#2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Newbie012 wants to merge2 commits intoopenapi-ts:main
base:main
Choose a base branch
Loading
fromNewbie012:fix-avoid-duplicate-enum-with-no-prefix

Conversation

Newbie012
Copy link

Changes

given the following settings:

enum: true,rootTypes: true,rootTypesNoSchemaPrefix: true

the generated output will declare an enum and a type with the same name. This PR will avoid redeclaring a type if its node is an enum.

How to Review

The PR is quite minimal - code adjustment + a test

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@Newbie012Newbie012 requested a review froma team as acode ownerJune 8, 2025 15:41
@Newbie012Newbie012 requested a review fromgzm0June 8, 2025 15:41
@netlifyNetlify
Copy link

netlifybot commentedJun 8, 2025•
edited
Loading

👷 Deploy request foropenapi-ts pending review.

Visit the deploys page to approve it

NameLink
🔨 Latest commit39b374d

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJun 8, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:39b374d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gzm0
Copy link
Contributor

@duncanbeevers can I hand this over to you? I'm not feeling sufficiently comfortable with the internals to review this.

@duncanbeevers
Copy link
Contributor

@gzm0 Yes I can take this. I think it's a duplicate of a couple other issues, so I'll see about taking some time to gather the various bugs + fixes together to pick the best solution.

@duncanbeeversduncanbeevers self-requested a reviewJune 10, 2025 21:09
@iw-tundo
Copy link

Hi, I'm also encountering this issue. Do you know if you have a rough estimate of when this will be merged and released?
@duncanbeevers

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gzm0gzm0Awaiting requested review from gzm0gzm0 is a code owner automatically assigned from openapi-ts/maintainers

@duncanbeeversduncanbeeversAwaiting requested review from duncanbeevers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Newbie012@gzm0@duncanbeevers@iw-tundo
[8]ページ先頭
©2009-2025 Movatter.jp