Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

openapi-fetch:Request parameter in client methods was ignored#2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sgrishchenko wants to merge5 commits intoopenapi-ts:main
base:main
Choose a base branch
Loading
fromsgrishchenko:main

Conversation

sgrishchenko
Copy link

@sgrishchenkosgrishchenko commentedMay 25, 2025
edited
Loading

Changes

Small bag is fixed. Before these changesRequest parameter in client methods was ignored.

Also, it turned out thatRequest parameter was not added inRequestOptions, so I added the corresponding declaration.

Also, it turned out thatRequest parameter was not added in API docs, so I tried to add it there.

How to Review

I provided a unit test to demonstrate the problem, you can run it with and without my fix and check the results.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@sgrishchenkosgrishchenko requested a review froma team as acode ownerMay 25, 2025 20:07
@netlifyNetlify
Copy link

netlifybot commentedMay 25, 2025
edited
Loading

👷 Deploy request foropenapi-ts pending review.

Visit the deploys page to approve it

NameLink
🔨 Latest commit771b03f

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedMay 25, 2025
edited
Loading

🦋 Changeset detected

Latest commit:771b03f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
openapi-fetchPatch
openapi-react-queryPatch
swr-openapiPatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kerwanpkerwanpAwaiting requested review from kerwanpkerwanp is a code owner automatically assigned from openapi-ts/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@sgrishchenko

[8]ページ先頭

©2009-2025 Movatter.jp