Ran the commandpnpm run update:examples which created 129 new files and updated 69, none of which seemed related to this change. Let me know if you wan't me to do it anyways.

How to Review

Refer to comments in originalPR 1901
Validate tests are satisfactory

Checklist

Unit tests updated
docs/ updated (if necessary)
pnpm run update:examples run (only applicable for openapi-typescript)

hontas requested a review froma team as acode owner

May 5, 2025 08:21

hontas requested a review fromkerwanp

May 5, 2025 08:21

Copy link

netlifybot commentedMay 5, 2025•
edited
Loading

👷 Deploy request foropenapi-ts pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`b299279`

Copy link

changeset-botbot commentedMay 5, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:b299279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
openapi-typescript	Minor
swr-openapi	Major

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Pontus Lundin added4 commits

May 5, 2025 10:34

add support for pattern properties

234d304

add tests

004fd40

fix fmt issue in test file

3630d74

add changeset

b299279

hontas force-pushed thepattern-properties branch fromf508c21 tob299279Compare

May 5, 2025 08:34

Copy link

Contributor

gzm0 commentedMay 5, 2025

@kerwanp LMK if you'd like to hand-off review to me here.
@hontas TY so much for taking this over!

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm afraid the logic here is not correct: We need to addUNKNOWN iffadditionalProperties: true (or it is unset andoptions.ctx.additionalProperties is set).

So for example, for the following, we should generatestring | unknown:

type:objectadditionalProperties:truepatternProperties:".*":type:string

IIUC the current code would only generatestring.

(FWIW: I realize this was wrong in my PR as well).

packages/openapi-typescript/test/transform/schema-object/object.test.ts

		given: { type: "object", patternProperties: {} },
		want: `{
		[key: string]: unknown;
		}`,

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think this test case is correct. I think the result here should be the empty object.

IIUC openapi-typescript works under the base assumption that the default foradditionalProperties is false (which is not actually the JSON schema default). So in this object type, no keys are allowed:

The additionalProperties keyword is used to control the handling of extra stuff, that is, properties whose names are not listed in the properties keyword or match any of the regular expressions in the patternProperties keyword. By default any additional properties are allowed.

From:https://json-schema.org/understanding-json-schema/reference/object#additionalproperties

@duncanbeevers maybe you can double check my understanding of the--additional-properties flag?