Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Attach fetch response to SWR data/error#2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Tommos0 wants to merge2 commits intoopenapi-ts:main
base:main
Choose a base branch
Loading
fromTommos0:patch-1

Conversation

Tommos0
Copy link

@Tommos0Tommos0 commentedApr 8, 2025•
edited
Loading

Changes

It is useful to have the original fetch response available in the hook result. For instance to distinguish the HTTP status code in case of anerror. Since SWR only returnserror /data properties, this provides an escape hatch to be able to access to originalfetch response, as returned by theopenapi-fetch client.

This will probably fail for JSON bodies that parse to primitives (null/string).

#2238

Checklist

I was unable to run the test suite, making it hard to add / update unit tests for me.

It is useful to have the original fetch response available in the hook result. For instance to distinguish the HTTP status code in case of an `error`.Since SWR only returns `error` / `data` properties, this provides an escape hatch to be able to access to original `fetch` response, as returned by the `openapi-fetch` client.
@Tommos0Tommos0 requested a review froma team as acode ownerApril 8, 2025 08:26
@netlifyNetlify
Copy link

netlifybot commentedApr 8, 2025•
edited
Loading

👷 Deploy request foropenapi-ts pending review.

Visit the deploys page to approve it

NameLink
🔨 Latest commit4070c42

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedApr 8, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:4070c42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpowdrwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Not opposed to this fix itself, but we will need a test to make sure this doesn’t regress in the future.

Could you describe the error you were seeing when running the test suite? Are you on the current LTS Node version (22) and did you follow the instructions inCONTRIBUTING.md?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@drwpowdrwpowdrwpow requested changes

@duncanbeeversduncanbeeversAwaiting requested review from duncanbeeversduncanbeevers is a code owner automatically assigned from openapi-ts/maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Tommos0@drwpow
[8]ページ先頭
©2009-2025 Movatter.jp