- Notifications
You must be signed in to change notification settings - Fork343
Fix misc. live tests#795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
joseharriaga commentedOct 30, 2025
- Extend delays for VectorStore tests to mitigate flakiness
- Upgrade Moderation tests to the new omni-moderation-latest model to avoid failures when using the older text-moderation-stable model
- Move image generation tool in Responses to ResponsesToolTests.cs
- Add a delay to file search tool test in Responses to mitigate flakiness
- Re-record as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the moderations tests to use the newomni-moderation-latest model instead of the deprecatedtext-moderation-stable model. The changes include:
- Updating the default model for moderations test scenarios
- Adjusting test assertions to match the new model's score thresholds
- Updating session recordings to reflect the new API responses
- Reorganizing test methods between test files
- Adding necessary delays for consistency in vector store tests
Reviewed Changes
Copilot reviewed 11 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Utility/TestHelpers.cs | Updates default moderation model from "text-moderation-stable" to "omni-moderation-latest" |
| tests/Moderations/ModerationsTests.cs | Adjusts violence score thresholds from 0.5 to 0.2 and updates model name assertion |
| tests/SessionRecords/ModerationsTests/*.json | Updates recorded API responses for the new omni-moderation model with additional fields |
| tests/SessionRecords/VectorStoresTests/*.json | Updates session recordings with new test data and reduced file counts |
| tests/Responses/ResponsesToolTests.cs | Adds System.Threading using statement and moves image generation tests from ResponsesTests |
| tests/Responses/ResponsesTests.cs | Removes image generation tests (moved to ResponsesToolTests) |
| tests/Assistants/Assistants.VectorStoresTests.cs | Increases delays from 1-2 seconds to 10 seconds for vector store operations |
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
b1ad4b1 intomainUh oh!
There was an error while loading.Please reload this page.