Feat: separate tool_call_item and tool_call_output_item in stream events#974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

gdisk wants to merge2 commits intoopenai:main

base:main

Choose a base branch

fromgdisk:main

Open

Feat: separate tool_call_item and tool_call_output_item in stream events#974

gdisk wants to merge2 commits intoopenai:mainfromgdisk:main

+130 −9

Conversation

Copy link

gdisk commentedJun 30, 2025

Summary

During my analysis of the streaming API (run_streamed) results, I noticed that tool_call_item and tool_call_output_item events are currently being emitted concurrently upon tool call completion (as evidenced in #831). This implementation conflates what should logically be distinct events. The current PR addresses this by properly separating these event triggers to better reflect the actual workflow.

Test plan

The test file is created intests namedtest_stream_events.py.Run the test script below to test.

pytest -s test_stream_events.py

The test result is:

======================================================================== test session starts ======================================================================== platform win32 -- Python 3.12.10, pytest-8.3.5, pluggy-1.5.0rootdir: D:\moon\projects\openai-agents-pythonconfigfile: pyproject.tomlplugins: anyio-4.9.0, inline-snapshot-0.22.3, asyncio-0.26.0, mock-3.14.0asyncio: mode=Mode.AUTO, asyncio_default_fixture_loop_scope=session, asyncio_default_test_loop_scope=functioncollected 1 item                                                                                                                                                      tests\test_stream_events.py === Run starting ===Agent updated: Joker-- Message output: a_message-- Tool was called at 1751271106971851300-- Tool output: success! at 1751271109987313900-- Message output: done=== Run complete ===.========================================================================= 1 passed in 3.07s =========================================================================

Issue number

#831

Checks

I've added new tests (if relevant)
I've runmake lint andmake format
I've made sure tests pass

Feat: separate tool_call_item and tool_call_output_item in stream events

5daa8e1

Copy link

legeRise commentedJun 30, 2025

hi i was just trying to get an effect of calling a tool with its name displays with a spinner and then after sometime the output
and
noticed both events are emitting at the same time

so is it fixed Now? can i use it

Copy link

Author

gdisk commentedJul 1, 2025

hi i was just trying to get an effect of calling a tool with its name displays with a spinner and then after sometime the output and noticed both events are emitting at the same time
so is it fixed Now? can i use it

Yeah, just check out this PR and run the tests to verify.

Copy link

legeRise commentedJul 1, 2025•
edited
Loading

hi i was just trying to get an effect of calling a tool with its name displays with a spinner and then after sometime the output and noticed both events are emitting at the same time
so is it fixed Now? can i use it
Yeah, just check out this PR and run the tests to verify.

thank you so much. it works. hope it gets merged soon