Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make Runner an abstract base class#720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pakrym-oai merged 24 commits intomainfrompakrym/runner-class
Jun 18, 2025
Merged

Conversation

pakrym-oai
Copy link
Contributor

@pakrym-oaipakrym-oai commentedMay 20, 2025
edited
Loading

Allows replacing the runner and trace provider logic.

- Introduce a DEFAULT_RUNNER global and a set_default_runner() function to allow callers to specify a default Runner for agent runs.- Update Runner.run, run_sync, and run_streaming to use DEFAULT_RUNNER if set, otherwise fallback to DefaultRunner.- Add detailed docstrings to run, run_sync, and run_streaming methods for clarity on agent execution flow and exceptions.
This commit renames the abstract and concrete methods run_impl, run_sync_impl, and run_streamed_impl in the Runner and DefaultRunner classes to _run_impl, _run_sync_impl, and _run_streamed_impl (or _start_streaming as appropriate) for improved naming consistency. Updates all method calls and test mocks accordingly. No behavior changes.
…lace global with accessor- Move TraceProvider and related logic from setup.py to new provider.py module- Replace direct GLOBAL_TRACE_PROVIDER references with get_trace_provider() accessor throughout tracing code- Update init and util imports to use get_trace_provider- Call set_trace_provider(TraceProvider()) on init- Remove ID and time generation logic from util, delegate to TraceProvider- Update SpanImpl to always use passed-in span_id
@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open for 10 days with no activity.

@github-actionsGitHub Actions
Copy link

This PR was closed because it has been inactive for 7 days since being marked as stale.

…mplementation- Add abstract TraceProvider base class to define tracing API- Move default tracing logic to DefaultTraceProvider- Update __init__.py to export both TraceProvider and DefaultTraceProvider, and use DefaultTraceProvider as default- Aligns span/trace management and enables alternative provider implementations
# Conflicts:#src/agents/__init__.py#src/agents/run.py
…itialized- Add get_default_runner to retrieve current default runner.- Always assign DEFAULT_RUNNER to a DefaultRunner at module init.- Replace fallback logic (`DEFAULT_RUNNER or DefaultRunner()`) with direct use of initialized DEFAULT_RUNNER.- Update __all__ in __init__.py to export get_default_runner.- Minor update to tracing/__init__.py __all__ for consistency.
…ls, _get_model) from DefaultRunner to Runner base class
@pakrym-oaipakrym-oai marked this pull request as ready for reviewJune 17, 2025 14:07
## Summary- rename DefaultRunner to DefaultAgentRunner and extend new AgentRunnerbase- remove `set_default_runner`/`get_default_runner` helpers- rename abstract methods on AgentRunner (no underscore)- update tests and imports for new API## Testing- `make format`- `make lint`- `make mypy`- `make tests`------https://chatgpt.com/codex/tasks/task_i_6851851acce8832099adc70d8197016c
class Runner:
class Runner(abc.ABC):
@abc.abstractmethod
async def _run_impl(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if these are meant to be overriden, we should remove the _ and document them

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not there anymore

"""The ID of the previous response, if any."""


class AgentRunner(abc.ABC):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add a comment saying this is not part of public interface, and that you should not use/subclass it? (We'll change that in the future once we feel better about it)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

@@ -0,0 +1,294 @@
from __future__ import annotations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if possible can you try and mark as a "move" so blame is preserved?

…UNNER to new AgentRunner if passed Noneconftest.py: add autouse fixture to clear DEFAULT_AGENT_RUNNER before each test
@pakrym-oaipakrym-oai merged commit0cf503e intomainJun 18, 2025
5 checks passed
@pakrym-oaipakrym-oai deleted the pakrym/runner-class branchJune 18, 2025 00:41
niv-hertz pushed a commit to coralogix/openai-agents-python that referenced this pull requestJun 20, 2025
niv-hertz added a commit to coralogix/openai-agents-python that referenced this pull requestJun 23, 2025
* Fix function_schema name override bug (openai#872)## Summary- ensure `name_override` is always used in `function_schema`- test name override when docstring info is disabled## Testing- `make format`- `make lint`- `make mypy`- `make tests`Resolvesopenai#860------https://chatgpt.com/codex/tasks/task_i_684f1cf885b08321b4dd3f4294e24ca2* adopted float instead of timedelta for timeout parameters (openai#874)I replaced the `timedelta` parameters for MCP timeouts with `float`values, addressing issueopenai#845 .Given that the MCP official repository has incorporated these changes in[this PR](modelcontextprotocol/python-sdk#941),updating the MCP version in openai-agents and specifying the timeouts asfloats should be enough.* Prompts support (openai#876)Add support for the new openai prompts feature.* v0.0.18 (openai#878)* Allow replacing AgentRunner and TraceProvider (openai#720)* Prepare 0.0.19 release (openai#895)* Added support for "return" handoffs (#1)* Fix bug in Reasoning with `store=False`---------Co-authored-by: Rohan Mehta <rm@openai.com>Co-authored-by: Daniele Morotti <58258368+DanieleMorotti@users.noreply.github.com>Co-authored-by: pakrym-oai <pakrym@openai.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rm-openairm-openairm-openai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@pakrym-oai@rm-openai

[8]ページ先頭

©2009-2025 Movatter.jp