- Notifications
You must be signed in to change notification settings - Fork2.9k
fix #844: add resume helpers for MaxTurnsExceeded runs#2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
thomas-lab-openai wants to merge4 commits intomainChoose a base branch fromtlab/max-turns-final-answer
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+269 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
seratch commentedNov 14, 2025
You’ve assigned@rm-openai as a reviewer, so he may come up with other suggestions, but personally, I feel adding the methods to the exception class this way may not be a clean design. I would add some kind of helper that handles the max exceed error and resumes. Aside from the implementation details, I’m not yet sure whether it helps when the max turns are exceeded. Even if you resume it, it might hit the max turns again. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requestresolves#844:
resume()and syncresume_sync()helpers onMaxTurnsExceededthat replay one final turn with an optional user prompt, reusing the prior agent, context, and a copy of the originalRunConfigRunResultandRunErrorDetailsto retain the effective RunConfig, so guardrail/tool settings, tracing metadata, and other knobs survive into a resume attempttool_choice="none"while still respecting any other model settings (e.g., temperature) that the caller suppliedexamples/basic/max_turns_resume.pysample that demonstrates recovering after a hard turn limit