- Notifications
You must be signed in to change notification settings - Fork2k
fix: ensure ResponseUsage token fields are int, not None (fixes #1179)#1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+3 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
seratch approved these changesJul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
rm-openai approved these changesJul 18, 2025
23404e8
intoopenai:main 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
When using streaming responses, some models or API endpoints may return
usage
fields (prompt_tokens
,completion_tokens
,total_tokens
) asNone
or omit them entirely. The current implementation passes these values directly to theResponseUsage
Pydantic model, which expects integers. This causes a validation error:3 validation errors for ResponseUsage
input_tokens
Input should be a valid integer [type=int_type, input_value=None, input_type=NoneType]
output_tokens
Input should be a valid integer [type=int_type, input_value=None, input_type=NoneType]
total_tokens
Input should be a valid integer [type=int_type, input_value=None, input_type=NoneType]
Solution
This PR ensures that all token fields passed to
ResponseUsage
are always integers. If any of the fields areNone
or missing, they default to0
. This is achieved by usingor 0
and explicitis not None
checks for nested fields.Key changes:
input_tokens
,output_tokens
,total_tokens
fields useor 0
fallback.Impact
fixes#1179