- Notifications
You must be signed in to change notification settings - Fork2k
Initial pass at PostgreSQL session management#1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Wanted to get the code up here in case there was some discussion on how to do things. Will look into the documentation tomorrow. |
Got a little stuck on the I took a stab at documentation. Open to feedback on structuring. Overall I wanted the postgres session to be in extensions because psycopg can be somewhat heavy on certain platforms. But I wasn't sure if the docs should go with extensions or the other memory docs. |
11b6963
to9b8973f
Compare* Add postgres_session.py * Implements session management using PostgreSQL * Accepts a pool as a default argument * Additional class method for creation from a connection string* Add optional-dependency for psycopgSigned-off-by: Aidan Jensen <aidan@artificial.com>
Signed-off-by: Aidan Jensen <aidan@artificial.com>
Signed-off-by: Aidan Jensen <aidan@artificial.com>
fb82be7
to9ab1728
Compare* Fix warning from opening a pool in the constructor:https://www.psycopg.org/psycopg3/docs/news_pool.html#psycopg-pool-3-2-2* Add integration tests that can be run locally* Fix get_items with limitSigned-off-by: Aidan Jensen <aidan@artificial.com>
9ab1728
toff857ed
Compare
Uh oh!
There was an error while loading.Please reload this page.
Summary
Test plan
Tests were written mocking the postgres calls. This was tested locally against a docker postgres database, with a variety of input messages.
Issue number
Related to#745
Checks
make lint
andmake format