Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fallback to function name for unnamed output_guardrail decorators#1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

romankhan26
Copy link
Contributor

Overview:
This PR improves the output_guardrail behavior by ensuring a valid name is always assigned to the guardrail, even when the decorator is used without parentheses or without explicitly providing a name.

Problem:
Previously, when the decorator @output_guardrail was used without a name (and without parentheses), the name attribute of the guardrail remained None. This resulted in issues during runtime — specifically, the guardrail name did not appear in result.input_guardrail_results, making it harder to trace or debug guardrail outputs.

While the OutputGuardrail.get_name() method correctly defaults to the function name when name is None, this method is not used inside the decorator. Hence, unless a name is provided explicitly, the OutputGuardrail instance holds None for its name internally.

Solution:
This PR updates the decorator logic to:

Automatically fallback to the function name if the name parameter is not provided.

Ensure that the guardrail always has a meaningful identifier, which improves downstream behavior such as logging, debugging, and result tracing.

Example Behavior Before:

@output_guardrail
def validate_output(...):
Name remains None

Example Behavior After:

@output_guardrail
def validate_output(...):
Name becomes "validate_output" automatically

Why it matters:
This small change avoids hidden bugs or inconsistencies in downstream systems (like guardrail_results) that rely on guardrail names being defined. It also brings consistent behavior whether or not parentheses are used in the decorator.

@seratchseratch added enhancementNew feature or request feature:core labelsJul 15, 2025
Copy link
Member

@seratchseratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Similar change to#1053 ; it should be good to go

Copy link
Member

@seratchseratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lint and test errors need to be resolved

@romankhan26
Copy link
ContributorAuthor

@seratch
Resolved!

@seratchseratch requested a review fromrm-openaiJuly 18, 2025 00:06
@rm-openairm-openai merged commit4b8f40e intoopenai:mainJul 18, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@seratchseratchseratch approved these changes

@rm-openairm-openairm-openai approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or requestfeature:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@romankhan26@seratch@rm-openai

[8]ページ先頭

©2009-2025 Movatter.jp