- Notifications
You must be signed in to change notification settings - Fork2k
Fix handling of text_message_outputs output structure in parallel translation example#1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mshsheikh wants to merge1 commit intoopenai:mainChoose a base branch frommshsheikh:patch-11
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…nslation example**Problem**:The code assumed `ItemHelpers.text_message_outputs()` returned a single string per result (e.g., `"Hola mundo"`), but it actually returns a **list of strings** (e.g., `["Hola", "Mundo"]`). This caused a `TypeError` when joining outputs.**Example of Failure**:```pythonoutputs = [ ["Hola", "Mundo"], # From text_message_outputs ["Buenos días"], ["Cómo estás"],]translations = "\n\n".join(outputs) # ❌ TypeError: can't join list to str```**Changes**:- Wrap `text_message_outputs(...)` with `" ".join(...)` to safely flatten each agent’s output into a single string:```python outputs = [ " ".join(ItemHelpers.text_message_outputs(res_1.new_items)), " ".join(ItemHelpers.text_message_outputs(res_2.new_items)), " ".join(ItemHelpers.text_message_outputs(res_3.new_items)), ]```**Benefits**:- Prevents `TypeError` by ensuring all outputs are strings.- Maintains consistent formatting for the final joined output.- Makes the example robust and easier to understand for users.This change ensures the parallel translation workflow works reliably, even when agent outputs vary in structure.
Thanks for reporting this. I don't think this is the fundamental solution as the helper method is supposed to return a single string:https://github.com/openai/openai-agents-python/blob/v0.1.0/src/agents/items.py#L277-L284 could you help us identify the cause of the unexpected behavior? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
documentationImprovements or additions to documentation needs-more-infoWaiting for a reply/more info from the author
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The code assumed
ItemHelpers.text_message_outputs()
returned a single string per result (e.g.,"Hola mundo"
), but it actually returns alist of strings (e.g.,["Hola", "Mundo"]
). This caused aTypeError
when joining outputs.Example of Failure:
Changes:
text_message_outputs(...)
with" ".join(...)
to safely flatten each agent’s output into a single string:Benefits:
TypeError
by ensuring all outputs are strings.This change ensures the parallel translation workflow works reliably, even when agent outputs vary in structure.