Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix handling of text_message_outputs output structure in parallel translation example#1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mshsheikh wants to merge1 commit intoopenai:main
base:main
Choose a base branch
Loading
frommshsheikh:patch-11

Conversation

mshsheikh
Copy link
Contributor

Problem:
The code assumedItemHelpers.text_message_outputs() returned a single string per result (e.g.,"Hola mundo"), but it actually returns alist of strings (e.g.,["Hola", "Mundo"]). This caused aTypeError when joining outputs.

Example of Failure:

outputs= [    ["Hola","Mundo"],# From text_message_outputs    ["Buenos días"],    ["Cómo estás"],]translations="\n\n".join(outputs)# ❌ TypeError: can't join list to str

Changes:

  • Wraptext_message_outputs(...) with" ".join(...) to safely flatten each agent’s output into a single string:
outputs= [" ".join(ItemHelpers.text_message_outputs(res_1.new_items))," ".join(ItemHelpers.text_message_outputs(res_2.new_items))," ".join(ItemHelpers.text_message_outputs(res_3.new_items)),  ]

Benefits:

  • PreventsTypeError by ensuring all outputs are strings.
  • Maintains consistent formatting for the final joined output.
  • Makes the example robust and easier to understand for users.

This change ensures the parallel translation workflow works reliably, even when agent outputs vary in structure.

…nslation example**Problem**:The code assumed `ItemHelpers.text_message_outputs()` returned a single string per result (e.g., `"Hola mundo"`), but it actually returns a **list of strings** (e.g., `["Hola", "Mundo"]`). This caused a `TypeError` when joining outputs.**Example of Failure**:```pythonoutputs = [    ["Hola", "Mundo"],  # From text_message_outputs    ["Buenos días"],    ["Cómo estás"],]translations = "\n\n".join(outputs)  # ❌ TypeError: can't join list to str```**Changes**:- Wrap `text_message_outputs(...)` with `" ".join(...)` to safely flatten each agent’s output into a single string:```python  outputs = [      " ".join(ItemHelpers.text_message_outputs(res_1.new_items)),      " ".join(ItemHelpers.text_message_outputs(res_2.new_items)),      " ".join(ItemHelpers.text_message_outputs(res_3.new_items)),  ]```**Benefits**:- Prevents `TypeError` by ensuring all outputs are strings.- Maintains consistent formatting for the final joined output.- Makes the example robust and easier to understand for users.This change ensures the parallel translation workflow works reliably, even when agent outputs vary in structure.
@seratchseratch added documentationImprovements or additions to documentation needs-more-infoWaiting for a reply/more info from the author labelsJul 14, 2025
@seratch
Copy link
Member

Thanks for reporting this. I don't think this is the fundamental solution as the helper method is supposed to return a single string:https://github.com/openai/openai-agents-python/blob/v0.1.0/src/agents/items.py#L277-L284 could you help us identify the cause of the unexpected behavior?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentationImprovements or additions to documentationneeds-more-infoWaiting for a reply/more info from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mshsheikh@seratch

[8]ページ先頭

©2009-2025 Movatter.jp