- Notifications
You must be signed in to change notification settings - Fork2k
Realtime: send session.update event at connection/handoffs#1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
+293 −146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJul 14, 2025
Merged
rm-openai added a commit that referenced this pull requestJul 14, 2025
jhills20 approved these changesJul 14, 2025
rm-openai added a commit that referenced this pull requestJul 14, 2025
The model listens to websocket events in a separate task, and thesession receives those events in on_event. So if there's e.g. awebsocket or json exception, it's silently dropped. Similar to thestreaming text agents, we should:- capture exceptions separately- raise them in `async for event in session` loop.Added tests to verify.---[//]: # (BEGIN SAPLING FOOTER)*#1112*#1111* __->__#1107*#1106
rm-openai added a commit that referenced this pull requestJul 14, 2025
5888cf2 intomain 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is what tells the model about tools, tool choice, model etc etc.