- Notifications
You must be signed in to change notification settings - Fork2k
Retry: Add tool_name to ToolContext for generic tool handlers#1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… tool_context.from_agent_context, Aligned formatting in _run_impl.py
Co-authored-by: Kazuhiro Sera <seratch@openai.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Apart from the changes under ./docs, looks good to me;@rm-openai can you take a look?
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
72d0d75
intoopenai:mainUh oh!
There was an error while loading.Please reload this page.
This is a follow-up to pr#1043 The original changes were reverted due to missing updates in RealtimeSession, which caused runtime test failures.
This PR:
tool_name
andtool_call_id
additions toToolContext
.RealtimeSession._handle_tool_call
to instantiateToolContext
withtool_name=event.name
andtool_call_id=event.call_id
.Closes#1030