- Notifications
You must be signed in to change notification settings - Fork2k
Feat/prompts caching#1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
amri369 wants to merge12 commits intoopenai:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Feat/prompts caching#1087
+273 −25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Integrate prompts list caching in MCP Servers. This allows agents to fetch prompts from local memory when
cache_prompts_listis set toTrue. Otherwise, every time an agent runs, it callslist_prompts()on the MCP Server.Key changes:
list_promptsin_MCPServerWithClientSessionto integrate caching using the same design pattern as caching integration inlist_tools.test_server_caching_workstotest_server_caching_prompts_worksin tests/mcp/test_caching.py.Note: This PR does not implement caching in
get_promptwhich can be useful in certain situations.Test plan
Unit tests: Added 1 unit test in tests/mcp/test_caching.py to cover prompts list caching.
Example verification: Created working example with MCP server and client.
All tests pass: 523/523 tests passing after adding optional dependencies
Checks
[x] I've added new tests (if relevant)
[x] I've added/updated the relevant documentation
[x] I've run make lint and make format
[x] I've made sure tests pass