- Notifications
You must be signed in to change notification settings - Fork2k
fix: Apply strict JSON schema validation in FunctionTool constructor#1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+5 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Linked Issue:#992 |
seratch approved these changesJul 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
rm-openai approved these changesJul 18, 2025
de8accc
intoopenai:main 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
salah9003 commentedJul 19, 2025
من هنا إلى الأعلى 👍🏿 👍🏿 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where directly created
FunctionTool
objects fail with OpenAI's Responses API due to missingadditionalProperties: false
in the JSON schema, while the@function_tool
decorator works correctly.Problem
The documentation example for creating
FunctionTool
objects directly fails with:This creates an inconsistency between
FunctionTool
and@function_tool
behavior, both of which havestrict_json_schema=True
by default.Solution
__post_init__
method toFunctionTool
dataclassensure_strict_json_schema()
whenstrict_json_schema=True
@function_tool
decoratorTesting
The fix can be verified by running the reproduction case from the issue: