- Notifications
You must be signed in to change notification settings - Fork777
Make ConcurrentMultiSpanProcessor fork safe#4862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
gregoiredx wants to merge1 commit intoopen-telemetry:mainChoose a base branch fromgregoiredx:fork-safe-concurrent-multi-span-processor
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Make ConcurrentMultiSpanProcessor fork safe#4862
gregoiredx wants to merge1 commit intoopen-telemetry:mainfromgregoiredx:fork-safe-concurrent-multi-span-processor
+11 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
linux-foundation-easyclabot commentedDec 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
3abcc2e tof98d672CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
ConcurrentMultiSpanProcessoris not "fork safe". This MR tries to solve this problem.Forking a threaded process is not a good idea in the first place, citing the Python doc, seehttps://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
Also, the OTel Python SDK suggest to only initialize the SDK post fork, seehttps://opentelemetry-python.readthedocs.io/en/latest/examples/fork-process-model/README.html
Nevertheless, on an existing code base, it's not always easy to avoid all forks. So it looks like a good idea to try and make the SDK as fork safe as possible.
Note:
BatchProcessoris already relying onregister_at_forkused here, seeopentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Line 125 in102fec2
Fixes#2349
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
It's quite hard to unit test.
An equivalent patch is currently running in our stack.
Does This PR Require a Contrib Repo Change?
?
Checklist: