Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[logs] Rename LogRecordProcessor.emit to on_emit#4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lzchen merged 5 commits intoopen-telemetry:mainfromhectorhdzg:hectorhdzg/onemit
Jun 26, 2025

Conversation

@hectorhdzg
Copy link
Member

@hectorhdzghectorhdzg commentedJun 19, 2025•
edited
Loading

Description

Rename LogRecordProcessor.emit to on_emit to align with specification
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#onemit

Fixes#4312

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

@hectorhdzghectorhdzg requested a review froma team as acode ownerJune 19, 2025 23:15
@tammy-baylis-swi
Copy link
Contributor

Thanks for another one@hectorhdzg ! I think theAPI should also be updated.

hectorhdzg reacted with thumbs up emoji

@hectorhdzg
Copy link
MemberAuthor

Thanks for reviewing@tammy-baylis-swi, I looked into the API as well, Logger "emit" is actually the expected method name, on_emit is only applicable to LogRecordProcessors, I could be missing something though.

@lzchen
Copy link
Contributor

Thanks for reviewing@tammy-baylis-swi, I looked into the API as well, Logger "emit" is actually the expected method name, on_emit is only applicable to LogRecordProcessors, I could be missing something though.

I believe this is correct.

@lzchenlzchen merged commit07700dd intoopen-telemetry:mainJun 26, 2025
449 of 450 checks passed
@github-project-automationgithub-project-automationbot moved this fromReady for review toDone in@xrmx's Python PR digestJun 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xrmxxrmxxrmx approved these changes

@lzchenlzchenlzchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logs SDK: consider renamingLogRecordProcessor.emit toon_emit

4 participants

@hectorhdzg@tammy-baylis-swi@lzchen@xrmx
[8]ページ先頭
©2009-2025 Movatter.jp