open-telemetry/opentelemetry-pythonPublic

NotificationsYou must be signed in to change notification settings
Fork776
Star2.3k

Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use#4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

aabmass merged 36 commits intoopen-telemetry:mainfromDylanRussell:refactor_blrp

May 12, 2025

Merged

Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use#4562

aabmass merged 36 commits intoopen-telemetry:mainfromDylanRussell:refactor_blrp

May 12, 2025

Conversation

Copy link

Contributor

DylanRussell commentedApr 25, 2025•
edited by xrmx
Loading

Description

Make aBatchProcessor class which bothBatchSpanRecordProcessor andBatchLogRecordProcessor can use.

MoveBatchProcessor into a new_shared_internal folder in the SDK, so both processors can make use of it.

In a follow up PR, I will updateBatchSpanRecordProcessor to use this new class.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added unit tests

Does This PR Require a Contrib Repo Change?

Checklist:

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

DylanRusselland others added12 commits

April 9, 2025 18:50

Refactor BatchLogRecordProcessor

217463e

Respond to comments

41cd520

Fix lint

8394244

Add delay for windows test.

0813487

Fix fork test

a088789

Merge branch 'main' into refactor_blrp

38b5420

Merge branch 'main' into refactor_blrp

3569be5

Initial Commit

3d2bbfc

Merge branch 'refactor_blrp' of github.com:DylanRussell/opentelemetry…

c2a96a7

…-python into refactor_blrp

Another commit

588a94e

Fix lint / precommit

6949778

Revert some old changes

56501d2

DylanRussell requested a review froma team as acode owner

April 25, 2025 17:54

DylanRusselland others added4 commits

April 28, 2025 15:49

Merge branch 'main' into refactor_blrp

449fc63

Fix lint issues

92d6464

Fix typo

44ca289

Fix lint and spellcheck

d8a2bea

xrmx added this to@xrmx's Python PR digest

Apr 29, 2025

xrmx moved this toReady for review in@xrmx's Python PR digest

Apr 29, 2025

xrmx reviewed

Apr 29, 2025

View reviewed changes

opentelemetry-sdk/tests/shared_internal/test_batch_processor.py OutdatedShow resolvedHide resolved

Update test to use BatchLogRecordProcessor instead of BatchProcessor

6e1149f

xrmx reviewed

Apr 30, 2025

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.pyShow resolvedHide resolved

DylanRussell added3 commits

April 30, 2025 15:19

Add a sleep to see if it helps this test pass on pypy 3.8

7cecb51

fix lint and precommit

62237c4

Add sleep to try to fix test..

f592787

Copy link

ContributorAuthor

DylanRussell commentedApr 30, 2025•
edited
Loading

Nevermind.. was able to get the test working

DylanRussell added4 commits

April 30, 2025 19:11

Fix flaky test attemptopen-telemetry#2

07af14c

Fix test again..

b2e9217

Fix test again

8133635

Try again

fa71f76

DylanRussell added2 commits

May 1, 2025 13:20

Fix again..

ff1d626

Reintroduce weakref, I accidentlly undid that change in my last PR

495f087

xrmx approved these changes

May 6, 2025

View reviewed changes

DylanRusselland others added2 commits

May 6, 2025 13:56

Add changelog

1ee12cf

Merge branch 'main' into refactor_blrp

e424c05

aabmass reviewed

May 8, 2025

View reviewed changes

Copy link

Member

aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, just a few comments on design and typing

opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py OutdatedShow resolvedHide resolved

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py OutdatedShow resolvedHide resolved

Respond to comments on PR

3937d2e

lzchen approved these changes

May 12, 2025

View reviewed changes

DylanRussell added6 commits

May 12, 2025 14:14

Merge branch 'main' of github.com:DylanRussell/opentelemetry-python i…

8b3aa91

…nto refactor_blrp

Make BatchProcessor a member of BLRP instead of having BLRP subclass it

5cc1fc4

Run precommit

7546092

Use a generic Protocol for the Exporter

fa07dd2

Minor change

b857ab0

Fix bad changelog mearge

b62feeb

aabmass approved these changes

May 12, 2025

View reviewed changes

Copy link

Member

aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome!

opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py OutdatedShow resolvedHide resolved

opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.pyShow resolvedHide resolved

Respond to comments..

1ddc257

aabmass merged commit037e9cb intoopen-telemetry:main

May 12, 2025

480 of 481 checks passed

github-project-automationbot moved this fromReady for review toDone in@xrmx's Python PR digest

May 12, 2025

DylanRussell mentioned this pull request

May 15, 2025

REQUEST: New membership for DylanRussellopen-telemetry/community#2748

Closed

hectorhdzg mentioned this pull request

Jun 19, 2025

Logs SDK:LoggerProvider is still functional aftershutdown#4317

Closed

lukeina2z mentioned this pull request

Oct 29, 2025

Bump ADOT Python version to 0.13.0 and OTel dependencies to 1.37.0/0.58b0aws-observability/aws-otel-python-instrumentation#524

Merged

mxiamxia pushed a commit to aws-observability/aws-otel-python-instrumentation that referenced this pull request

Oct 30, 2025

Bump ADOT Python version to 0.13.0 and OTel dependencies to 1.37.0/0.…

d3b22ba

…58b0 (#524)This PR updates the upstream OpenTelemetry Python dependency to itsSeptember 2025 release; Upgrading from version 1.33.1/0.54b1 to1.37.0/0.58b0.It also resolves several conflicts between the following OTel PRs andexisting ADOT patches:starlette: Remove maximum version constraintopen-telemetry/opentelemetry-python-contrib#3456Make a BatchProcessor class which both BatchSpanRecordProcessor andBatchLogRecordProcessor can useopen-telemetry/opentelemetry-python#4562Make exporter timeout encompass retries/backoffs, add jitter tobackoffs, cleanup code a bitopen-telemetry/opentelemetry-python#4564Update BatchSpanProcessor to use new BatchProcessor classopen-telemetry/opentelemetry-python#4580Fix issue where deadlock can occur over logging._lockopen-telemetry/opentelemetry-python#4636Tests Performedtox -e linttox -e spellchecktox -e 3.9-test-aws-opentelemetry-distrotox -e 3.10-test-aws-opentelemetry-distrotox -e 3.11-test-aws-opentelemetry-distrotox -e 3.12-test-aws-opentelemetry-distrotox -e 3.13-test-aws-opentelemetry-distroSmoke/contract tests: ./gradlewappsignals-tests:contract-tests:contractTestsBy submitting this pull request, I confirm that you can use, modify,copy, and redistribute this contribution, under the terms of yourchoice.

Labels

None yet

Movatterモバイル変換

Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use#4562

Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use#4562

Uh oh!

Conversation

DylanRussell commentedApr 25, 2025• edited by xrmxLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Does This PR Require a Contrib Repo Change?

Checklist:

Uh oh!

Uh oh!

Uh oh!

DylanRussell commentedApr 30, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

aabmass left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aabmass left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DylanRussell commentedApr 25, 2025•
edited by xrmx
Loading

DylanRussell commentedApr 30, 2025•
edited
Loading