- Notifications
You must be signed in to change notification settings - Fork776
export and shutdown timeouts for all OTLP exporters#3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bd19a3d to3cd93c9CompareArnatious commentedMar 7, 2024
I based behavior decisions off the described behavior in#2663 (comment) - namely, the shortest timeout always wins. Processor timeout logic is unaffected - if the processor has a shorter timeout or is tracking a deadline for a batch, it passes that to I chose to create a helper object rather than splice this into the inheritance hierarchy to avoid having a mixin with |
a28c110 toba50c4cComparepmcollins commentedMay 8, 2024
@Arnatious apologies for the delay and thanks for this PR -- improvements to the area you've addressed are super important. However, perhaps this is too much of a good thing all at once. Do you have availability to break these changes down into smaller PRs? This would make things much easier on reviewers. |
This is the first change in a chain of commits to rework the retrymechanic. It is based on the work ofopen-telemetry#3764 and basically trying to landthe changes proposed by this monolithic commit step by step.The plan is roughly to proceed in these steps:* Extract retry mechanic from GRPC exporters* Consolidate HTTP with GRPC exporter retry implementation* Pipe timeout through RetryingExporter* Make exporter lock protect the whole export instead of just a single iteration* Make timeout float instead of int* Add back-off with jitterIt's pretty likely that the plan will change along the way.
This is the first change in a chain of commits to rework the retrymechanic. It is based on the work ofopen-telemetry#3764 and basically trying to landthe changes proposed by this monolithic commit step by step.The plan is roughly to proceed in these steps:* Extract retry mechanic from GRPC exporters* Consolidate HTTP with GRPC exporter retry implementation* Pipe timeout through RetryingExporter* Make exporter lock protect the whole export instead of just a single iteration* Make timeout float instead of int* Add back-off with jitterIt's pretty likely that the plan will change along the way.
This is the first change in a chain of commits to rework the retrymechanic. It is based on the work ofopen-telemetry#3764 and basically trying to landthe changes proposed by this monolithic commit step by step.The plan is roughly to proceed in these steps:* Extract retry mechanic from GRPC exporters* Consolidate HTTP with GRPC exporter retry implementation* Pipe timeout through RetryingExporter* Make exporter lock protect the whole export instead of just a single iteration* Make timeout float instead of int* Add back-off with jitterIt's pretty likely that the plan will change along the way.
This is the first change in a chain of commits to rework the retrymechanic. It is based on the work ofopen-telemetry#3764 and basically trying to landthe changes proposed by this monolithic commit step by step.The plan is roughly to proceed in these steps:* Extract retry mechanic from GRPC exporters* Consolidate HTTP with GRPC exporter retry implementation* Pipe timeout through RetryingExporter* Make exporter lock protect the whole export instead of just a single iteration* Make timeout float instead of int* Add back-off with jitterIt's pretty likely that the plan will change along the way.
This is the first change in a chain of commits to rework the retrymechanic. It is based on the work ofopen-telemetry#3764 and basically trying to landthe changes proposed by this monolithic commit step by step.The plan is roughly to proceed in these steps:* Extract retry mechanic from GRPC exporters* Consolidate HTTP with GRPC exporter retry implementation* Pipe timeout through RetryingExporter* Make exporter lock protect the whole export instead of just a single iteration* Make timeout float instead of int* Add back-off with jitterIt's pretty likely that the plan will change along the way.
Arnatious commentedNov 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Superceded by#4564 (thanks!) |
Uh oh!
There was an error while loading.Please reload this page.
Description
This is a solution to several issues related to the current synchronous OTLP exporters.
Currently, OTLP exporters have a couple of pain points
This PR implements a new utility class,
opentelemetry.exporter.otlp.proto.common.RetryingExporter, that fixes the above issues. It also significantly refactors the existing OTLP exporters to use this, and extracts retry related logic from their test suites.Attempts were made to maintain the call signature of public APIs, though in several cases **kwargs were added to ensure future proofing, and positional arguments were renamed to create a consistent interface.
OTLP exporters will create a RetryingExporter, passing in a function performing a single export attempt as well as the OTLPExporter's timeout and export result type.
Example
Fixes#3309
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests were added for the RetryableExporter in
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_retryable_exporter.py, as well as for the backoff generator inexporter/opentelemetry-exporter-otlp-proto-common/tests/test_backoff.py. Tests were updated throughout the http and grpc otlp exporters, and retry related logic was removed in all cases but for GRPC metrics, which can be split and therefore needed another layer of deadline checking.Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: