Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add line-specific filter to catch warning#3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
srikanthccv merged 4 commits intoopen-telemetry:mainfromocelotl:issue_3163
Feb 13, 2023

Conversation

@ocelotl
Copy link
Contributor

@ocelotlocelotl commentedFeb 6, 2023•
edited
Loading

Fixes#3163

This is another approach to solve the issue#3147 intends to solve but without usingcatch_warnings which is not thread-safe.

@ocelotlocelotl added the Skip ChangelogPRs that do not require a CHANGELOG.md entry labelFeb 6, 2023
@ocelotlocelotl requested a review froma teamFebruary 6, 2023 19:01
@ocelotlocelotl self-assigned thisFeb 6, 2023
@srikanthccvsrikanthccv merged commitacc11a0 intoopen-telemetry:mainFeb 13, 2023
@ocelotlocelotl deleted the issue_3163 branchFebruary 13, 2023 21:59
@ocelotlocelotl mentioned this pull requestFeb 13, 2023
6 tasks
@rafikdraoui
Copy link

Thanks!

This fixes the immediate bug of warnings being wrongfully enabled, but it doesn't fix the underlying issue of the need to work around this specific deprecation warning.

I'm not familiar with the project, so I could be wrong, but it seems to me like the real fix for this issue would be to stop using the deprecated function in the first place.

If the workaround is a temporary measure to bridge the gap between deprecation and complete removal of the function, then it might be worth adding a comment about it as a note to people unfamiliar with the reason behind it, and as a reminder to clean it up later 🙂

cojenco reacted with thumbs up emoji

cojenco added a commit to googleapis/python-storage that referenced this pull requestMay 30, 2024
* feat: OTel tracing media ops initial instrumentation* use download class name as span name* avoid asserting filtered warnings from otel peropen-telemetry/opentelemetry-python#3164
cojenco added a commit to googleapis/python-storage that referenced this pull requestJun 26, 2024
* feat: introduce OpenTelemetry Tracing decorators (#1257)* feat: introduce OpenTelemetry Tracing decorators* update test coverage* add tests, update fixture* update noxfile, extras; remove print* update unit test* review comments* feat: instrument metadata ops with OTel tracing (#2) (#1267)* feat: instrument metadata ops with Otel tracing* update README plus test* update decorator name per review session* fix typo in readme* feat: OTel tracing media ops initial instrumentation (#1280)* feat: OTel tracing media ops initial instrumentation* use download class name as span name* avoid asserting filtered warnings from otel peropen-telemetry/opentelemetry-python#3164* add copyright and preview note* comments
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lzchenlzchenlzchen approved these changes

@shalevrshalevrshalevr approved these changes

+1 more reviewer

@srikanthccvsrikanthccvsrikanthccv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocelotlocelotl

Labels

Skip ChangelogPRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove DeprecationWarning without disturbing warning filters

5 participants

@ocelotl@rafikdraoui@lzchen@srikanthccv@shalevr
[8]ページ先頭
©2009-2025 Movatter.jp