- Notifications
You must be signed in to change notification settings - Fork2.8k
[Bugfix] Allow custom visualizer#3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
xiexinch merged 1 commit intoopen-mmlab:dev-1.xfrommmeendez8:bugfix/allow-custom-visualizersDec 4, 2023
Merged
[Bugfix] Allow custom visualizer#3455
xiexinch merged 1 commit intoopen-mmlab:dev-1.xfrommmeendez8:bugfix/allow-custom-visualizersDec 4, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xiexinch approved these changesDec 4, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull requestApr 5, 2024
Thanks for your contribution and we appreciate it a lot. The followinginstructions would make your pull request more healthy and more easilyget feedback. If you do not understand some items, don't worry, justmake the pull request and seek help from maintainers.## MotivationCurrent Visualization Hook can only get instances of`SegLocalVisualizer`. This makes impossible to use any other customimplementation.## ModificationThis PR just allows to instantiate a different visualizer (followingmmdetection implementation):https://github.com/open-mmlab/mmdetection/blob/main/mmdet/engine/hooks/visualization_hook.py#L58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Current Visualization Hook can only get instances of
SegLocalVisualizer. This makes impossible to use any other custom implementation.Modification
This PR just allows to instantiate a different visualizer (following mmdetection implementation):
https://github.com/open-mmlab/mmdetection/blob/main/mmdet/engine/hooks/visualization_hook.py#L58