- Notifications
You must be signed in to change notification settings - Fork2.8k
[Feature] Support VPD Depth Estimator#3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
xiexinch approved these changesSep 13, 2023
emily-lin pushed a commit to emily-lin/mmsegmentation that referenced this pull requestNov 18, 2023
Thanks for your contribution and we appreciate it a lot. The followinginstructions would make your pull request more healthy and more easilyget feedback. If you do not understand some items, don't worry, justmake the pull request and seek help from maintainers.## MotivationSupport depth estimation algorithm [VPD](https://github.com/wl-zhao/VPD)## Modification1. add VPD backbone2. add VPD decoder head for depth estimation3. add a new segmentor `DepthEstimator` based on `EncoderDecoder` fordepth estimation4. add an integrated metric that calculate common metrics in depthestimation5. add SiLog loss for depth estimation 6. add config for VPD ## BC-breaking (Optional)Does the modification introduce changes that break thebackward-compatibility of the downstream repos?If so, please describe how it breaks the compatibility and how thedownstream projects should modify their code to keep compatibility withthis PR.## Use cases (Optional)If this PR introduces a new feature, it is better to list some use caseshere, and update the documentation.## Checklist1. Pre-commit or other linting tools are used to fix the potential lintissues.7. The modification is covered by complete unit tests. If not, pleaseadd more unit test to ensure the correctness.8. If the modification has potential influence on downstream projects,this PR should be tested with downstream projects, like MMDet orMMDet3D.9. The documentation has been modified accordingly, like docstring orexample tutorials.
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull requestApr 5, 2024
Thanks for your contribution and we appreciate it a lot. The followinginstructions would make your pull request more healthy and more easilyget feedback. If you do not understand some items, don't worry, justmake the pull request and seek help from maintainers.## MotivationSupport depth estimation algorithm [VPD](https://github.com/wl-zhao/VPD)## Modification1. add VPD backbone2. add VPD decoder head for depth estimation3. add a new segmentor `DepthEstimator` based on `EncoderDecoder` fordepth estimation4. add an integrated metric that calculate common metrics in depthestimation5. add SiLog loss for depth estimation 6. add config for VPD ## BC-breaking (Optional)Does the modification introduce changes that break thebackward-compatibility of the downstream repos?If so, please describe how it breaks the compatibility and how thedownstream projects should modify their code to keep compatibility withthis PR.## Use cases (Optional)If this PR introduces a new feature, it is better to list some use caseshere, and update the documentation.## Checklist1. Pre-commit or other linting tools are used to fix the potential lintissues.7. The modification is covered by complete unit tests. If not, pleaseadd more unit test to ensure the correctness.8. If the modification has potential influence on downstream projects,this PR should be tested with downstream projects, like MMDet orMMDet3D.9. The documentation has been modified accordingly, like docstring orexample tutorials.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support depth estimation algorithmVPD
Modification
DepthEstimatorbased onEncoderDecoderfor depth estimationBC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist