- Notifications
You must be signed in to change notification settings - Fork2.8k
[Feature] Support depth metrics#3297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
xiexinch merged 4 commits intoopen-mmlab:dev-1.xfromBen-Louis:lupeng/support-depth-metricsAug 31, 2023
Merged
[Feature] Support depth metrics#3297
xiexinch merged 4 commits intoopen-mmlab:dev-1.xfromBen-Louis:lupeng/support-depth-metricsAug 31, 2023
+303 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xiexinch approved these changesAug 31, 2023
Comment on lines 30 to 31
| crop_type (str, optional): Type of cropping to be used during | ||
| evaluation. |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might list optional values
Comment on lines 126 to 128
| if self.crop_type == 'nyu_crop': | ||
| crop_mask = torch.zeros_like(valid_mask) | ||
| crop_mask[45:471, 41:601] = 1 |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might add a ref link.
xiexinch approved these changesAug 31, 2023
xiexinch approved these changesAug 31, 2023
emily-lin pushed a commit to emily-lin/mmsegmentation that referenced this pull requestNov 18, 2023
Thanks for your contribution and we appreciate it a lot. The followinginstructions would make your pull request more healthy and more easilyget feedback. If you do not understand some items, don't worry, justmake the pull request and seek help from maintainers.Please describe the motivation of this PR and the goal you want toachieve through this PR.Support metrics for the depth estimation task, including RMSE, ABSRel,and etc.Please briefly describe what modification is made in this PR.Does the modification introduce changes that break thebackward-compatibility of the downstream repos?If so, please describe how it breaks the compatibility and how thedownstream projects should modify their code to keep compatibility withthis PR.Using the following configuration to compute depth metrics on NYU```pythondataset_type = 'NYUDataset'data_root = 'data/nyu'test_pipeline = [ dict(type='LoadImageFromFile'), dict(dict(type='LoadDepthAnnotation', depth_rescale_factor=1e-3)), dict( type='PackSegInputs', meta_keys=('img_path', 'depth_map_path', 'ori_shape', 'img_shape', 'pad_shape', 'scale_factor', 'flip', 'flip_direction', 'category_id'))]val_dataloader = dict( batch_size=1, num_workers=4, persistent_workers=True, sampler=dict(type='DefaultSampler', shuffle=False), dataset=dict( type=dataset_type, data_root=data_root, test_mode=True, data_prefix=dict( img_path='images/test', depth_map_path='annotations/test'), pipeline=test_pipeline))test_dataloader = val_dataloaderval_evaluator = dict(type='DepthMetric', max_depth_eval=10.0, crop_type='nyu')test_evaluator = val_evaluator```Example log:1. Pre-commit or other linting tools are used to fix the potential lintissues.2. The modification is covered by complete unit tests. If not, pleaseadd more unit test to ensure the correctness.3. If the modification has potential influence on downstream projects,this PR should be tested with downstream projects, like MMDet orMMDet3D.4. The documentation has been modified accordingly, like docstring orexample tutorials.nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull requestApr 5, 2024
Thanks for your contribution and we appreciate it a lot. The followinginstructions would make your pull request more healthy and more easilyget feedback. If you do not understand some items, don't worry, justmake the pull request and seek help from maintainers.## MotivationPlease describe the motivation of this PR and the goal you want toachieve through this PR.Support metrics for the depth estimation task, including RMSE, ABSRel,and etc.## ModificationPlease briefly describe what modification is made in this PR.## BC-breaking (Optional)Does the modification introduce changes that break thebackward-compatibility of the downstream repos?If so, please describe how it breaks the compatibility and how thedownstream projects should modify their code to keep compatibility withthis PR.## Use cases (Optional)Using the following configuration to compute depth metrics on NYU```pythondataset_type = 'NYUDataset'data_root = 'data/nyu'test_pipeline = [ dict(type='LoadImageFromFile'), dict(dict(type='LoadDepthAnnotation', depth_rescale_factor=1e-3)), dict( type='PackSegInputs', meta_keys=('img_path', 'depth_map_path', 'ori_shape', 'img_shape', 'pad_shape', 'scale_factor', 'flip', 'flip_direction', 'category_id'))]val_dataloader = dict( batch_size=1, num_workers=4, persistent_workers=True, sampler=dict(type='DefaultSampler', shuffle=False), dataset=dict( type=dataset_type, data_root=data_root, test_mode=True, data_prefix=dict( img_path='images/test', depth_map_path='annotations/test'), pipeline=test_pipeline))test_dataloader = val_dataloaderval_evaluator = dict(type='DepthMetric', max_depth_eval=10.0, crop_type='nyu')test_evaluator = val_evaluator```Example log:## Checklist1. Pre-commit or other linting tools are used to fix the potential lintissues.2. The modification is covered by complete unit tests. If not, pleaseadd more unit test to ensure the correctness.3. If the modification has potential influence on downstream projects,this PR should be tested with downstream projects, like MMDet orMMDet3D.4. The documentation has been modified accordingly, like docstring orexample tutorials.Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Support metrics for the depth estimation task, including RMSE, ABSRel, and etc.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
Using the following configuration to compute depth metrics on NYU
Example log:

Checklist