- Notifications
You must be signed in to change notification settings - Fork2.8k
[Enhance] Support multi-band image for Mosaic#2748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
CLAassistant commentedMar 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@## dev-1.x #2748 +/- ##===========================================- Coverage 83.46% 83.46% -0.01%=========================================== Files 147 147 Lines 8669 8670 +1 Branches 1303 1303 =========================================== Hits 7236 7236- Misses 1203 1204 +1 Partials 230 230
Flags with carried forward coverage won't be shown.Click here to find out more.
Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here. ☔ View full report in Codecov by Sentry. |
## ModificationI changed the hardcoded 3 channel length to dynamic channel length in`np.full` function arguments.This modification enables `RandomMosaic` transform to supportmultispectral image (e.g. RGB image with NIR band) or bi-temporal imagepairs for change detection task.## Checklist1. Pre-commit or other linting tools are used to fix the potential lintissues.2. The modification is covered by complete unit tests. If not, pleaseadd more unit test to ensure the correctness.3. If the modification has potential influence on downstream projects,this PR should be tested with downstream projects, like MMDet orMMDet3D.4. The documentation has been modified accordingly, like docstring orexample tutorials.
Uh oh!
There was an error while loading.Please reload this page.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
I changed the hardcoded 3 channel length to dynamic channel length in
np.fullfunction arguments.This modification enables
RandomMosaictransform to support multispectral image (e.g. RGB image with NIR band) or bi-temporal image pairs for change detection task.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist