packages/stripe/src/functions.ts (1)

157-169:Derive currency from the item price and finalize/pay invoice for immediate charge

• Currency: Avoid defaulting to 'usd' which can cause Stripe errors if the subscription is in another currency. Prefer the subscription’s currency, then the item’s price currency.
• Immediate invoicing: Creating with auto_advance: true typically finalizes later (not instant). To charge immediately, finalize and pay the invoice.

Apply this diff:

-        await stripe.invoiceItems.create({-            customer: updatedSubscription.customer as string,-            amount: priceDifferenceAmount,-            currency: updatedSubscription.currency || 'usd',-            description: 'Price upgrade difference',-        });--        // Create invoice immediately-        const invoice = await stripe.invoices.create({-            customer: updatedSubscription.customer as string,-            auto_advance: true,-        });+        await stripe.invoiceItems.create(+            {+                customer: updatedSubscription.customer as string,+                amount: priceDifferenceAmount,+                currency:+                    updatedSubscription.currency ||+                    newItem.price?.currency ||+                    undefined,+                description: `Price upgrade difference (${currentItem.price?.id} → ${newItem.price?.id})`,+            }+        );++        // Create, finalize, and pay invoice immediately+        const invoice = await stripe.invoices.create({+            customer: updatedSubscription.customer as string,+            collection_method: 'charge_automatically',+            auto_advance: false,+        });+        await stripe.invoices.finalizeInvoice(invoice.id);+        await stripe.invoices.pay(invoice.id);

Note:

• If neither subscription nor price currency is present, consider throwing explicitly rather than relying on a default to avoid currency mismatches.

if (!currency) throw new Error('Currency not found on subscription or price');

apps/web/client/src/server/api/routers/subscription/subscription.ts (1)

165-169:Confirm post-upgrade state sync and “immediate” invoicing semantics

• This path no longer updates the DB (unlike the downgrade path which writes schedule info). If your webhook is responsible for syncing the new price into the DB, please confirm it covers this upgrade scenario and that the UI can render the new tier promptly without relying solely on webhook latency.
• “Immediate” invoicing: upgradeSubscription currently creates an invoice with auto_advance: true, which is finalized automatically later (typically up to ~1 hour). If you need truly immediate charge/collection, consider finalizing and paying the invoice explicitly in upgradeSubscription (see suggestion in functions.ts review).

packages/stripe/src/functions.ts (3)

137-146:Optional: Add idempotency to write operations

Retries could double-charge (duplicate invoice items). Consider idempotency keys for invoice item and invoice creation.

Example:

awaitstripe.invoiceItems.create(data,{idempotencyKey:`upgrade-item-${subscriptionId}-${subscriptionItemId}-${priceId}`});constinvoice=awaitstripe.invoices.create(invoiceData,{idempotencyKey:`upgrade-invoice-${subscriptionId}-${subscriptionItemId}-${priceId}`});

---

137-146:Optional: Ensure price fields are available without expansions

In some API versions/setups, nested price objects may not include all fields unless expanded. If you encounter null unit_amount, retrieve the Price via stripe.prices.retrieve(priceId) or use expansions on the subscription update/retrieve.

Example:

constcurrentPriceObj=awaitstripe.prices.retrieve(currentPriceId!);constnewPriceObj=awaitstripe.prices.retrieve(priceId);

---

171-172:Return type and data shape

Consider returning both the updated subscription and invoice (if one is created) so callers can reflect immediate charges in the UI.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

packages/stripe/src/functions.ts (3)

127-140:Good: targeting the correct subscription item and nullish-checking unit_amount

Using subscriptionItemId to locate the item and checking unit_amount with a nullish guard avoids multi-item and 0-amount pitfalls.

---

153-166:Good: reading updated item by id and incorporating quantity into the delta

This addresses under-billing when quantity > 1 and avoids relying on index 0.

---

176-185:Nice: invoice is paid immediately after creation

This addresses prior feedback to ensure the upgrade transaction completes in one operation.

apps/web/template/next.config.mjs (1)

7-12:Turning off ESLint and TypeScript checks during builds can mask real issues—confirm intent or scope to non-CI builds

This will allow type and lint errors to ship unnoticed. If this is only to relax local template builds, gate it behind an env var so CI remains strict.

Apply this diff to enforce checks on CI while allowing local flexibility:

-    eslint: {-        ignoreDuringBuilds: true,-    },-    typescript: {-        ignoreBuildErrors: true,-    },+    eslint: {+        // Keep CI strict; allow local templates to build even with lint errors+        ignoreDuringBuilds: process.env.CI !== 'true',+    },+    typescript: {+        // Keep CI strict; allow local templates to build even with TS errors+        ignoreBuildErrors: process.env.CI !== 'true',+    },

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.